Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942889 - sys-apps/checkpolicy-3.7-r1 STABLEREQ
Summary: sys-apps/checkpolicy-3.7-r1 STABLEREQ
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: SE Linux Bugs
URL:
Whiteboard:
Keywords: CC-ARCHES, PullRequest
Depends on:
Blocks:
 
Reported: 2024-11-04 19:59 UTC by immolo
Modified: 2024-12-01 11:54 UTC (History)
1 user (show)

See Also:
Package list:
=sys-apps/checkpolicy-3.7-r1
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description immolo 2024-11-04 19:59:24 UTC
While looking into why the releng SELinux builds were failing I noticed that because we stabled libsepol-3.7 it caused the following error with checkpolicy-3.6:

checkpolicy.c: In function ‘check_level’:
checkpolicy.c:373:46: error: ‘level_datum_t’ {aka ‘struct level_datum’} has no member named ‘defined’; did you mean ‘notdefined’?
  373 |         if (!levdatum->isalias && !levdatum->defined) {
      |                                              ^~~~~~~
      |                                              notdefined
make: *** [Makefile:39: checkpolicy.o] Error 1

This can be resolved by also stabling checkpolicy-3.7-r1.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 03:33:10 UTC
Doesn't that mean that there's also a missing minimum version dep in checkpolicy?
Comment 2 immolo 2024-11-05 10:20:14 UTC
I did overlook this for context.

It should have already be set with https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-apps/checkpolicy/checkpolicy-3.7-r1.ebuild#n28 (Arguably this should be a BDEPEND as well.

3.6 has the same line as well so I'm not 100% sure why this isn't being honoured at the moment, but I'll move my testing out of Catalyst and into a real machine as your question has piqued my interesting.

In the meantime I don't see any new harm being caused be completing the STAVLEREQ so this should still happen IMO.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 10:28:32 UTC
(In reply to immolo from comment #2)
> I did overlook this for context.
> 
> It should have already be set with
> https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-apps/checkpolicy/
> checkpolicy-3.7-r1.ebuild#n28 (Arguably this should be a BDEPEND as well.
> 

The issue is the opposite side :(
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 10:29:20 UTC
(In reply to Sam James from comment #3)
> (In reply to immolo from comment #2)
> > I did overlook this for context.
> > 
> > It should have already be set with
> > https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-apps/checkpolicy/
> > checkpolicy-3.7-r1.ebuild#n28 (Arguably this should be a BDEPEND as well.
> > 
> 
> The issue is the opposite side :(

i.e. there's nothing to be done here in the end (except stabling), other than maybe pinning (ew), or adding a < dep to the old ebuilds
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 10:31:28 UTC
arm done
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 10:34:08 UTC
x86 done
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 10:34:10 UTC
amd64 done
Comment 8 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 15:55:07 UTC
arm64 done

all arches done
Comment 9 Larry the Git Cow gentoo-dev 2024-12-01 11:54:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f3637ec603e3b8787b118277568f202b351618a5

commit f3637ec603e3b8787b118277568f202b351618a5
Author:     Ian Jordan <immoloism@gmail.com>
AuthorDate: 2024-11-05 12:13:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 11:52:31 +0000

    sys-apps/checkpolicy: Force checkpoilcy-3.6 to use libsepol-3.6
    
    API change between libsepol-3.6 and 3.7 causes checkpolicy-3.6 to fail to compile when the wrong version of libsepol is used.
    
    Bug: https://bugs.gentoo.org/942889
    Signed-off-by: Ian Jordan <immoloism@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/39207
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/checkpolicy/checkpolicy-3.6.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)