commit c85d3cd324bd95113029b0a5c55b55a3f93bcaba Author: Fabian Groffen <grobian@gentoo.org> Date: Mon Jul 29 21:44:49 2024 +0200 app-crypt/gnupg-2.4.5-r2: accept pointer type differences on Solaris gnupg uses a function pointer for passing functions like getpeername which internally on Solaris use slightly different (yet compatible) definitions than gnupg's code specifies. This results in an error with newer compilers, but since there's basically not much wrong with this, suppress the warning for now. Signed-off-by: Fabian Groffen <grobian@gentoo.org> Please always file an upstream bug (or better yet, send a patch) and include a link to them for workarounds, especially modern C related ones.
So this bug is more about upstream references than documentation, I presume? Or is the documentation not clear from the description you pasted above? I see on the references point I can improve here, but the explanation looks quite explanatory?
The comment above it doesn't really explain why it's fine (more that there was a problem to begin with). It's obvious there is some mismatch if you're having to do that, it doesn't explain why you think it's okay or harmless here (i.e. there's no actual analysis there). The commit message has it but the comment doesn't. It should also link to an upstream report (which is the more important part).
Oh, I see. The ebuild mentions declaration using (socket_fd_t). The code uses (int) as more common on Linux, which is what (socket_fd_t) expands to on Solaris. That said, I see your point, give me a little time to sort this out.
Sure, no hurry - I just noticed it by chance and got curious ;) Thanks!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46573bad4a55a674fb24b26ec74565e988c44811 commit 46573bad4a55a674fb24b26ec74565e988c44811 Author: Fabian Groffen <grobian@gentoo.org> AuthorDate: 2024-11-03 11:30:42 +0000 Commit: Fabian Groffen <grobian@gentoo.org> CommitDate: 2024-11-03 11:35:11 +0000 app-crypt/gnupg: clarify/refresh Solaris workarounds - Filed upstream bug for the standards problems: https://dev.gnupg.org/T7368 - Define _XOPEN_SOURCE=500 for 2.4.6 to resolve the mismatch - Force configure machinery to kick in for 2.5.1 Closes: https://bugs.gentoo.org/942793 Signed-off-by: Fabian Groffen <grobian@gentoo.org> app-crypt/gnupg/gnupg-2.4.6-r1.ebuild | 9 +++++---- app-crypt/gnupg/gnupg-2.5.1.ebuild | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-)
