Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942682 - games-fps/eduke32-20240619.10591 unnecessary sdl2-mixer [midi] dependency
Summary: games-fps/eduke32-20240619.10591 unnecessary sdl2-mixer [midi] dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-01 19:44 UTC by klamp
Modified: 2024-12-23 20:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description klamp 2024-11-01 19:44:35 UTC
eduke32 unconditionally depends on sdl2-mixer with midi use flag enabled, but modified ebuild with "midi" dependency removed builds and runs against sdl2-mixer without midi seemingly fine, including music. This is because eduke32 has builtin adlib music code and opl3emu which converts soundtrack .mid files to sound samples.

This dependency should be (probably) required only when eduke32s "timidity" or "fluidsynth" use flags are turned on, but sdl2-mixer ebuild already contains this logic:

midi? ( any-of ( timidity fluidsynth ) ) timidity? ( midi ) fluidsynth? ( midi ) tremor? ( vorbis )

Reproducible: Always

Steps to Reproduce:
1. USE="-timidity -fluidsynth"  emerge -v eduke32

Actual Results:  
The following USE changes are necessary to proceed:
 (see "package.use" in the portage(5) man page for more details)
# required by games-fps/eduke32-20240619.10591::gentoo
# required by eduke32 (argument)
>=media-libs/sdl2-mixer-2.6.3-r1 midi
...


Expected Results:  
Package should merge without complaints
Comment 1 Larry the Git Cow gentoo-dev 2024-12-23 20:01:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b9aa95d3510708f39890bcd0f87d3ae3d8283054

commit b9aa95d3510708f39890bcd0f87d3ae3d8283054
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2024-12-23 19:30:06 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-12-23 19:31:52 +0000

    games-fps/eduke32: drop 20240619.10591
    
    Closes: https://bugs.gentoo.org/942682
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 games-fps/eduke32/Manifest                      |   1 -
 games-fps/eduke32/eduke32-20240619.10591.ebuild | 218 ------------------------
 2 files changed, 219 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b43b26179233245c62b6f170ba88a0b28f5c0574

commit b43b26179233245c62b6f170ba88a0b28f5c0574
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2024-12-23 19:29:31 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-12-23 19:31:51 +0000

    games-fps/eduke32: add 20241216.10600
    
    Bug: https://bugs.gentoo.org/942682
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 games-fps/eduke32/Manifest                      |   1 +
 games-fps/eduke32/eduke32-20241216.10600.ebuild | 218 ++++++++++++++++++++++++
 2 files changed, 219 insertions(+)