Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942379 - app-containers/docker Duplicate `depend()` in docker OpenRC initscript
Summary: app-containers/docker Duplicate `depend()` in docker OpenRC initscript
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-27 23:21 UTC by anthony
Modified: 2024-10-30 14:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description anthony 2024-10-27 23:21:53 UTC
This doesn't seem to be causing any issues, since it isn't an issue on my machine, and I don't think anyone else's complained about it, but the initscript for `docker` has two identical `depend()` sections.

There's a Gentoo patch that adds one `depend()`, reportedly due to bugs #842567 and #854231, but as of June 2022, the upstream initscript has also included its own `depend()` (see: https://github.com/moby/moby/commit/bb69104381805014eb7675682d204fe460a52388).

While duplicate `depend()` functions may not be an issue today, it's possible it'll be an issue later. Or, someone may assume one of those is supposed to be a typo'd idepend/rdepend/etc. instead.
Comment 1 Larry the Git Cow gentoo-dev 2024-10-30 14:02:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=451103c2b42be976a005295aff6e1ca27674fa59

commit 451103c2b42be976a005295aff6e1ca27674fa59
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2024-10-30 14:01:23 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2024-10-30 14:01:23 +0000

    app-containers/docker: add 27.3.1
    
    Closes: https://bugs.gentoo.org/942379
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 app-containers/docker/Manifest             |   1 +
 app-containers/docker/docker-27.3.1.ebuild | 319 +++++++++++++++++++++++++++++
 2 files changed, 320 insertions(+)