Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942306 - sci-libs/vtk-9.3.0-r3 - fails to compile with dev-libs/libfmt-11.0.2
Summary: sci-libs/vtk-9.3.0-r3 - fails to compile with dev-libs/libfmt-11.0.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal blocker
Assignee: Paul Zander
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 906077
  Show dependency tree
 
Reported: 2024-10-27 00:10 UTC by Timo van Veen
Modified: 2025-01-05 20:35 UTC (History)
11 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info and build log (vtk.log.gz,208.99 KB, application/gzip)
2024-10-27 00:12 UTC, Timo van Veen
Details
fix-libfmt-missing-join-include.patch (fmt.patch,2.67 KB, patch)
2024-11-29 17:23 UTC, Gabriel Marcano
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timo van Veen 2024-10-27 00:10:54 UTC
Upstream has fixed the issue in the linked pull request, but libfmt-11 cannot be unmasked until a stable release is ready.
Comment 1 Timo van Veen 2024-10-27 00:12:38 UTC
Created attachment 906942 [details]
emerge --info and build log
Comment 2 Petr Vaněk gentoo-dev 2024-11-25 12:30:10 UTC
How about restricting the libfmt version in ebuild for now, or backporting the patch?
Comment 3 Gabriel Marcano 2024-11-29 17:21:13 UTC
The upstream patch seems incomplete. I had to patch a ton more files to get compilation to succeed. My hypothesis is that upstream builds with IOSS_DEBUG_OUTPUT defined, which includes the necessary header throughout more of the project. Without that definition (as seems to be the case when building for Gentoo?), a ton more includes need to be added throughout the project. It should probably be cleaned up a bit, but I do have a patch I've applied myself to get vtk to build. I'll upload it in a second.
Comment 4 Gabriel Marcano 2024-11-29 17:23:55 UTC
Created attachment 912725 [details, diff]
fix-libfmt-missing-join-include.patch

his is my patch for building vtk against libfmt-11.0.2. Compared to upstream's patch, this adds the required fmt ranges.h include to a lot more places (pretty much anywhere that calls the libfmt join() function). With this I'm successfully able to build vtk-9.3.0-r3 against libfmt-11.0.2.
Comment 5 Bernd Feige 2024-12-03 16:17:00 UTC
(In reply to Gabriel Marcano from comment #4)
> Created attachment 912725 [details, diff] [details, diff]
> fix-libfmt-missing-join-include.patch
> 
> his is my patch for building vtk against libfmt-11.0.2. Compared to
> upstream's patch, this adds the required fmt ranges.h include to a lot more
> places (pretty much anywhere that calls the libfmt join() function). With
> this I'm successfully able to build vtk-9.3.0-r3 against libfmt-11.0.2.

Worked well here, thanks!
Comment 6 Rémi Cardona 2024-12-03 16:43:19 UTC
(In reply to Gabriel Marcano from comment #4)
> Created attachment 912725 [details, diff] [details, diff]
> fix-libfmt-missing-join-include.patch

WFM. vtk builds ok with it and freecad 1.0 seems to be happy to. Though I have yet to use the software for anything (other than launching it).
Comment 7 CaptainBlood 2024-12-03 18:57:06 UTC
In order to help to narrow source of issue in other sci-libs/vtk-9.3.0-r3 issues (e.g. #945731) it would be helpful if readers who have successfully build sci-libs/vtk-9.3.0-r3 could post the output of

emerge -p -v sci-libs/vtk-9.3.0-r3

Thks in advance
Comment 8 Rémi Cardona 2024-12-04 08:19:12 UTC
# emerge -pv vtk

These are the packages that would be merged, in order:

Calculating dependencies... done!
Dependency resolution took 6.75 s (backtrack: 0/20).

[ebuild   R    ] sci-libs/vtk-9.3.0-r3:0/9.3::gentoo  USE="freetype logging python qt6 rendering sdl threads views -all-modules -boost -cuda (-debug) -doc -examples -ffmpeg -gdal -gles2-only -imaging -java -las -mpi -mysql -odbc -opencascade -openmp -openvdb -pdal -postgres (-qt5) -tbb -test -tk -vtkm -web" PYTHON_SINGLE_TARGET="python3_12 -python3_10 -python3_11" VIDEO_CARDS="-nvidia" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB


HTH
Comment 9 CaptainBlood 2024-12-04 13:05:12 UTC
(In reply to Rémi Cardona from comment #8)
> HTH
Very helpful & time saving too.
TYVM
Comment 10 Larry the Git Cow gentoo-dev 2024-12-05 18:01:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=84af3342f9240ac12918d9c8cd95d788749cefd3

commit 84af3342f9240ac12918d9c8cd95d788749cefd3
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2024-12-05 12:17:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-05 18:01:14 +0000

    sci-libs/vtk: 9.3.1 support libfmt-11
    
    Closes: https://bugs.gentoo.org/942306
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/vtk/files/vtk-9.3.1-fix-fmt-11.patch | 70 +++++++++++++++++++++++++++
 sci-libs/vtk/vtk-9.3.1.ebuild                 |  1 +
 2 files changed, 71 insertions(+)
Comment 11 Sven Wegener gentoo-dev 2025-01-05 09:43:17 UTC
*** Bug 945942 has been marked as a duplicate of this bug. ***
Comment 12 Larry the Git Cow gentoo-dev 2025-01-05 20:35:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=099675b4d87b58545cadcef958c7633a8e7e9762

commit 099675b4d87b58545cadcef958c7633a8e7e9762
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2024-12-10 12:26:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-05 20:33:29 +0000

    sci-libs/vtk: 9.3.0-r3 backport libfmt-11 patch
    
    Closes: https://bugs.gentoo.org/945942
    Bug: https://bugs.gentoo.org/942306
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/vtk/vtk-9.3.0-r3.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)