Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942299 - sys-apps/ethtool: missing dependency on virtual/pkgconfig
Summary: sys-apps/ethtool: missing dependency on virtual/pkgconfig
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-26 18:53 UTC by Alexander Zubkov
Modified: 2024-10-28 12:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.txt,5.25 KB, text/plain)
2024-10-26 18:53 UTC, Alexander Zubkov
Details
build log (ethtool-build.log,4.63 KB, text/plain)
2024-10-26 18:54 UTC, Alexander Zubkov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Zubkov 2024-10-26 18:53:06 UTC
sys-apps/ethtool during build with USE=netlink tries to use pkg-config, and fails if it is absent. But it does not have build dependency on virtual/pkgconfig for example.
Here you can see in configure script that with --enable-netlink it uses pkg-config:
https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/tree/configure.ac#n77

Reproducible: Always

Steps to Reproduce:
docker run --rm -it --cap-add=SYS_PTRACE --cap-add=SYS_ADMIN gentoo/stage3:amd64-hardened-nomultilib-openrc

emerge-webrsync
emerge -C pkgconf
emerge -p sys-apps/ethtool
# -> only [ebuild  N     ] sys-apps/ethtool-6.9  USE="netlink"
emerge sys-apps/ethtool # fails
Actual Results:  
...
configure: error: in `/var/tmp/portage/sys-apps/ethtool-6.9/work/ethtool-6.9':
configure: error: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.
...

Expected Results:  
Successful build.

USE=-netlink emerge sys-apps/ethtool # this builds successfully

So I suppose ebuild for sys-apps/ethtool should contain additional dependency:

BDEPEND="netlink? ( virtual/pkgconfig )"
Comment 1 Alexander Zubkov 2024-10-26 18:53:54 UTC
Created attachment 906914 [details]
emerge --info
Comment 2 Alexander Zubkov 2024-10-26 18:54:16 UTC
Created attachment 906915 [details]
build log
Comment 3 Larry the Git Cow gentoo-dev 2024-10-28 12:41:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc49b387f6d6e807210c0b4c6c56ffd81902db26

commit fc49b387f6d6e807210c0b4c6c56ffd81902db26
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-28 12:40:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-28 12:40:34 +0000

    sys-apps/ethtool: add BDEPEND on pkgconfig
    
    Closes: https://bugs.gentoo.org/942299
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/ethtool/ethtool-6.10.ebuild | 5 ++++-
 sys-apps/ethtool/ethtool-6.6.ebuild  | 5 ++++-
 sys-apps/ethtool/ethtool-6.7.ebuild  | 5 ++++-
 sys-apps/ethtool/ethtool-6.9.ebuild  | 5 ++++-
 4 files changed, 16 insertions(+), 4 deletions(-)