Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942293 - www-client/elinks-0.17.1.1 - [ncurses-6.5] [meson] [libtool] ../.../http.c: error: implicit declaration of function ftp_curl_handle_error
Summary: www-client/elinks-0.17.1.1 - [ncurses-6.5] [meson] [libtool] ../.../http.c: e...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Felix Janda
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-10-26 15:11 UTC by Toralf Förster
Modified: 2024-11-11 22:53 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,21.98 KB, text/plain)
2024-10-26 15:11 UTC, Toralf Förster
Details
emerge-history.txt.xz (emerge-history.txt.xz,84.08 KB, application/x-xz)
2024-10-26 15:11 UTC, Toralf Förster
Details
environment (environment,153.81 KB, text/plain)
2024-10-26 15:11 UTC, Toralf Förster
Details
etc.clang.tar.xz (etc.clang.tar.xz,1.19 KB, application/x-xz)
2024-10-26 15:11 UTC, Toralf Förster
Details
etc.portage.tar.xz (etc.portage.tar.xz,24.36 KB, application/x-xz)
2024-10-26 15:11 UTC, Toralf Förster
Details
logs.tar.xz (logs.tar.xz,13.64 KB, application/x-xz)
2024-10-26 15:11 UTC, Toralf Förster
Details
qlist-info.txt.xz (qlist-info.txt.xz,96.43 KB, application/x-xz)
2024-10-26 15:11 UTC, Toralf Förster
Details
temp.tar.xz (temp.tar.xz,32.54 KB, application/x-xz)
2024-10-26 15:11 UTC, Toralf Förster
Details
www-client:elinks-0.17.1.1:20241026-114716.log (www-client:elinks-0.17.1.1:20241026-114716.log,160.42 KB, text/plain)
2024-10-26 15:11 UTC, Toralf Förster
Details
elinks-0.17.1.1-ftp.patch (elinks-0.17.1.1-ftp.patch,550 bytes, patch)
2024-10-29 11:07 UTC, Attila Tóth
Details | Diff
Proposed replacement of elinks-0.17.1.1-sftp.patch (elinks-0.17.1.1-sftp.patch,4.20 KB, patch)
2024-11-01 01:37 UTC, Felix Janda
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2024-10-26 15:11:48 UTC
too long lines were shrinked:

  622 | ftp_curl_handle_error(struct connection *conn, CURLcode res)
      | ^~~~~~~~~~~~~~~~~~~~~
[133/243] x86_64-pc-linux-gnu-gcc -Isrc/elinks.p -Isrc -I../elinks-0.17.1.1/src -I. -I../elinks-0.17.1.1 -I/usr/include/ncursesw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch '-DGETTEXT_PACKAGE="elinks"' '-DBUILD_ID=""' -O2 -pipe -march=native -fno-diagnostics-color -fno-stri
FAILED: src/elinks.p/protocol_curl_http.c.o 
x86_64-pc-linux-gnu-gcc -Isrc/elinks.p -Isrc -I../elinks-0.17.1.1/src -I. -I../elinks-0.17.1.1 -I/usr/include/ncursesw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch '-DGETTEXT_PACKAGE="elinks"' '-DBUILD_ID=""' -O2 -pipe -march=native -fno-diagnostics-color -fno-strict-aliasin
../elinks-0.17.1.1/src/protocol/curl/http.c: In function check_multi_info:
../elinks-0.17.1.1/src/protocol/curl/http.c:491:33: error: implicit declaration of function ftp_curl_handle_error; did you mean http_curl_handle_error? [-Wimplicit-function-declaration]
  491 |                                 ftp_curl_handle_error(conn, res);
      |                                 ^~~~~~~~~~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 23.0_desktop_gnome_systemd-20241017-150503

  UNMASKED:
    Please re-assign to ztrawhcse@ if you cannot reproduced it with regular meson.
  <dev-build/meson-9999
    Issues involving opaque types / incomplete typedefs should block bug 930805
  >=sys-libs/ncurses-6.5

  The attached etc.portage.tar.xz has all details.
  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-14 *
clang version 19.1.2
llvm-config: 19.1.2
Python 3.12.7
go version go1.23.2 linux/amd64
  [1]   php8.3 *
Available Ruby profiles:
  (none found)
Available Rust versions:
  [1]   rust-bin-1.82.0
  [2]   rust-1.82.0 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 11.0.25_p9 [openjdk-bin-11]
2)	Eclipse Temurin JDK 17.0.13_p11 [openjdk-bin-17]
3)	Eclipse Temurin JDK 21.0.5_p11 [openjdk-bin-21]
*)	Eclipse Temurin JDK 8.432_p06 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm
  [2]   openjdk-bin-11 
  [3]   openjdk-bin-17 
  [4]   openjdk-bin-21 

The Glorious Glasgow Haskell Compilation System, version 9.2.8

  HEAD of ::gentoo
commit 5c9c20c33a9dae765c13654fad0c5e04ff6d07ca
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Sat Oct 26 06:34:04 2024 +0000

    2024-10-26 06:34:03 UTC

emerge -qpvO =www-client/elinks-0.17.1.1
[ebuild     U ] www-client/elinks-0.17.1.1 [0.16.1.1-r100] USE="X bzip2 ftp gpm mouse nls ssl unicode xml zlib -bittorrent -brotli -debug -finger -gemini% -gnutls -gopher (-guile) -idn -javascript -libcss% -lua -lzma -nntp -perl -python -samba -test -tre -zstd" GUILE_SINGLE_TARGET="3-0 -2-2" LUA_SINGLE_TARGET="lua5-1 -lua5-3 -lua5-4 -luajit" PYTHON_SINGLE_TARGET="python3_12 -python3_10 -python3_11 -python3_13%"
Comment 1 Toralf Förster gentoo-dev 2024-10-26 15:11:49 UTC
Created attachment 906868 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2024-10-26 15:11:50 UTC
Created attachment 906869 [details]
emerge-history.txt.xz
Comment 3 Toralf Förster gentoo-dev 2024-10-26 15:11:51 UTC
Created attachment 906870 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2024-10-26 15:11:52 UTC
Created attachment 906871 [details]
etc.clang.tar.xz
Comment 5 Toralf Förster gentoo-dev 2024-10-26 15:11:53 UTC
Created attachment 906872 [details]
etc.portage.tar.xz
Comment 6 Toralf Förster gentoo-dev 2024-10-26 15:11:54 UTC
Created attachment 906873 [details]
logs.tar.xz
Comment 7 Toralf Förster gentoo-dev 2024-10-26 15:11:55 UTC
Created attachment 906874 [details]
qlist-info.txt.xz
Comment 8 Toralf Förster gentoo-dev 2024-10-26 15:11:56 UTC
Created attachment 906875 [details]
temp.tar.xz
Comment 9 Toralf Förster gentoo-dev 2024-10-26 15:11:58 UTC
Created attachment 906876 [details]
www-client:elinks-0.17.1.1:20241026-114716.log
Comment 10 Zentoo 2024-10-28 11:35:33 UTC
I confirm the issue if USE=ftp.
Comment 11 Larry the Git Cow gentoo-dev 2024-10-28 11:42:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0994847954dbf35b3933d1ecb2332d1684602e7

commit a0994847954dbf35b3933d1ecb2332d1684602e7
Author:     Felix Janda <felix.janda@posteo.de>
AuthorDate: 2024-10-28 01:40:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-28 11:41:06 +0000

    www-client/elinks: various bugfixes
    
    Closes: https://bugs.gentoo.org/933407
    Closes: https://bugs.gentoo.org/942286
    Closes: https://bugs.gentoo.org/942202
    Closes: https://bugs.gentoo.org/942293
    Signed-off-by: Felix Janda <felix.janda@posteo.de>
    Closes: https://github.com/gentoo/gentoo/pull/39134
    Signed-off-by: Sam James <sam@gentoo.org>

 www-client/elinks/elinks-0.17.1.1.ebuild           |  8 ++-
 www-client/elinks/elinks-9999.ebuild               |  4 +-
 www-client/elinks/files/elinks-0.17.1.1-sftp.patch | 63 +++++++++++++---------
 3 files changed, 48 insertions(+), 27 deletions(-)
Comment 12 Attila Tóth 2024-10-29 11:07:37 UTC
Created attachment 907228 [details, diff]
elinks-0.17.1.1-ftp.patch

Merged patch defines http_curl_handle_error, but added parts also have ftp_curl_handle_error, which is not handled. This patch adds that as well.
Comment 13 Felix Janda 2024-11-01 01:37:47 UTC
Created attachment 907498 [details, diff]
Proposed replacement of elinks-0.17.1.1-sftp.patch

Thanks for pointing this out. (The compilation error only occurs on >=gcc-14. In previous versions of gcc, the implicit function declaration is only a warning and compilation proceeds happily.)

Can you confirm that replacing elinks-0.17.1.1-sftp.patch by this attachment fixes the bug?
Comment 14 Attila Tóth 2024-11-07 21:40:37 UTC
(In reply to Felix Janda from comment #13)
> Created attachment 907498 [details, diff] [details, diff]
> Proposed replacement of elinks-0.17.1.1-sftp.patch
> 
> Thanks for pointing this out. (The compilation error only occurs on
> >=gcc-14. In previous versions of gcc, the implicit function declaration is
> only a warning and compilation proceeds happily.)
> 
> Can you confirm that replacing elinks-0.17.1.1-sftp.patch by this attachment
> fixes the bug?

It's not a replacement, but an addition to it.
Comment 15 Felix Janda 2024-11-08 19:35:33 UTC
(In reply to Attila Tóth from comment #14)
> It's not a replacement, but an addition to it.

I am aware of this, and have used your addition to create a replacement patch, see the newest attachment to this bug or the pull request.
Comment 16 Larry the Git Cow gentoo-dev 2024-11-11 22:53:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d61d6b38b78c075970c91a1a8468edc6394ecee

commit 2d61d6b38b78c075970c91a1a8468edc6394ecee
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2024-11-11 22:52:08 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2024-11-11 22:52:08 +0000

    www-client/elinks: Update 0.17.1.1-sftp patch to fix building with GCC 14
    
    Closes: https://bugs.gentoo.org/942293
    Closes: https://bugs.gentoo.org/942437
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 www-client/elinks/files/elinks-0.17.1.1-sftp.patch | 14 ++++++++++++++
 1 file changed, 14 insertions(+)