Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942131 - dev-java/icu4j-76.1 installs more files with FEATURES=test
Summary: dev-java/icu4j-76.1 installs more files with FEATURES=test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-10-25 09:26 UTC by Agostino Sarubbo
Modified: 2024-10-26 11:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-10-25 09:26:58 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-java/icu4j-76.1 installs more files with FEATURES=test.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue:
1) Install the package with FEATURES=test
2) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist_test )
3) Install the package without FEATURES=test
4) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist_notest )
5) See the diff between the two files ( diff -ru /tmp/qlist_test /tmp/qlist_notest )

On this machine:
- the installed files with FEATURES=test are 10
- the installed files without FEATURES=test are 9

This type of report comes from a check that is a bit outside of the tinderbox, that's the reason because build.log was not provided (however in cases like these the build.log doesn't help much) but if you need further help to diagnose this issue feel free to ask.

In any case I'm providing a diff.

DIFF:
--- /dev/fd/63  2024-10-25 10:19:45.220114443 +0200
+++ /dev/fd/62  2024-10-25 10:19:45.220114443 +0200
@@ -1,3 +1,4 @@
+/usr/bin/icu4j
 /usr/share/doc/icu4j-76.1/CONTRIBUTING.md.bz2
 /usr/share/doc/icu4j-76.1/html/APIChangeReport.html
 /usr/share/doc/icu4j-76.1/html/readme.html
Comment 1 Volkmar W. Pogatzki 2024-10-25 10:48:15 UTC
This is due to the line
JAVA_MAIN_CLASS="com.ibm.icu.dev.test.TestAll"

Could we unset JAVA_MAIN_CLASS in the eclass after usage?
Comment 2 Larry the Git Cow gentoo-dev 2024-10-26 07:23:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dcc0bd06b7a073696decb92f387f53e10c790a92

commit dcc0bd06b7a073696decb92f387f53e10c790a92
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2024-10-25 14:42:43 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-10-26 07:23:41 +0000

    dev-java/icu4j: adjust launcher #942131
    
    The ebuild was installing a wrong (with tests) or even no (without
    tests) launcher. The install phase of java-pkg-simple.eclass gets
    confused when there are more than one jar files.
    
    Closes: https://bugs.gentoo.org/942131
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/38836/commits/f6e074c87572a2eec4973fd27c674d0a0c5ba6c7
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 dev-java/icu4j/{icu4j-76.1.ebuild => icu4j-76.1-r1.ebuild} | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-26 11:01:22 UTC
Just want to say thanks for the nice commit message!