Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 942044 - app-office/ledger uses elog to recreate an optfeature like-functionality
Summary: app-office/ledger uses elog to recreate an optfeature like-functionality
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Erik Mackdanz
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-10-24 04:11 UTC by Lemon Lime
Modified: 2024-11-03 20:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lemon Lime 2024-10-24 04:11:42 UTC
This is not a bug, simply an QA change and a "ebuild consistency" type change.

I'll provide a patch shortly.
Comment 1 Lemon Lime 2024-10-24 04:15:23 UTC
(One of) The cool things about optfeature is that it will not show the message again if the package is already installed.

This works particularly well for the emacs' ledger-mode, as it has an ebuild. 
It does not work with the vim plugin since there is no ebuild at the moment.

I am unfamiliar with vim ebuilds, although, from what I've seen, they don't seem TOO complicated. 

Best regards ^_^
Comment 2 Larry the Git Cow gentoo-dev 2024-11-03 20:12:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e833bec6f11174789a0d685d66f63268e216e552

commit e833bec6f11174789a0d685d66f63268e216e552
Author:     Erik Mackdanz <stasibear@gentoo.org>
AuthorDate: 2024-11-03 19:36:46 +0000
Commit:     Erik Mackdanz <stasibear@gentoo.org>
CommitDate: 2024-11-03 20:11:31 +0000

    app-office/ledger: install contrib report script
    
    Closes: https://github.com/gentoo/gentoo/pull/39094
    Closes: https://bugs.gentoo.org/942044
    Closes: https://bugs.gentoo.org/942406
    Signed-off-by: Erik Mackdanz <stasibear@gentoo.org>

 app-office/ledger/ledger-3.3.2-r2.ebuild | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
Comment 3 Erik Mackdanz gentoo-dev 2024-11-03 20:13:35 UTC
I was unfamiliar with optfeature. Thanks!