Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 941762 - sys-kernel/linux-firmware-20241017: fails to unpack
Summary: sys-kernel/linux-firmware-20241017: fails to unpack
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chí-Thanh Christopher Nguyễn
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-18 12:36 UTC by Sam James
Modified: 2024-10-18 16:35 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-18 12:36:38 UTC
>>> Unpacking source...
>>> Source unpacked in /var/tmp/portage/sys-kernel/linux-firmware-20241017/work
 * ERROR: sys-kernel/linux-firmware-20241017::gentoo failed (prepare phase):
 *   The source directory '/var/tmp/portage/sys-kernel/linux-firmware-20241017/work/linux-firmware-20241017' doesn't exist
 *
 * Call stack:
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-18 12:37:14 UTC
@@ -13,13 +14,14 @@ if [[ ${PV} == 99999999* ]]; then
        EGIT_REPO_URI="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/${PN}.git"
 else
        if [[ -n "${MY_COMMIT}" ]]; then
-               SRC_URI="https://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/snapshot/${MY_COMMIT}.tar.gz -> ${P}.tar.gz"
+               SRC_URI="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/snapshot/${MY_COMMIT}.tar.gz -> ${P}.tar.gz"
                S="${WORKDIR}/${MY_COMMIT}"
        else
-               SRC_URI="https://mirrors.edge.kernel.org/pub/linux/kernel/firmware/${P}.tar.xz"
+               EGIT_REPO_URI="https://git.kernel.org/pub/scm/linux/kernel/git/firmware/${PN}.git"
+               EGIT_BRANCH="${PV}"
        fi

I think the issue is that this part leaves SRC_URI blank for non-snapshots. (We can't use EGIT_* for non-live ebuilds)
Comment 2 Larry the Git Cow gentoo-dev 2024-10-18 12:48:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=500e750607fd4ddfad72966a0fc716ebb2400453

commit 500e750607fd4ddfad72966a0fc716ebb2400453
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2024-10-18 12:47:35 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2024-10-18 12:47:35 +0000

    sys-kernel/linux-firmware: drop 20241017, remove until I fix
    
    Bug: https://bugs.gentoo.org/941762
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 .../linux-firmware/linux-firmware-20241017.ebuild  | 412 ---------------------
 1 file changed, 412 deletions(-)
Comment 3 Mike Pagano gentoo-dev 2024-10-18 12:50:00 UTC
Part of upstream's new changes is to call 'git ls-files' from one of their scripts.

I was trying to avoid patching that out, but it seems I may need to.
Comment 4 Larry the Git Cow gentoo-dev 2024-10-18 16:35:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19d98640fa73ee9a30639a0561d5972a2a4e0efe

commit 19d98640fa73ee9a30639a0561d5972a2a4e0efe
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2024-10-18 16:29:39 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2024-10-18 16:35:31 +0000

    sys-kernel/linux-firmware: add 20241017, with user contributed patch
    
    Committed with patch authored by Emil Velikov to workaround
    the check_whency.py failing for installation from source tarball.
    
    Thank-you, Emil.  Will track upstream PR and incorporate any fixes
    identified.
    
    See: https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/339/diffs?commit_id=040558a71ea1b3f579d98e561dc56afb9842b78c
    Closes: https://bugs.gentoo.org/941762
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 sys-kernel/linux-firmware/Manifest                 |   1 +
 .../files/linux-firmware-copy-firmware-r5.patch    |  36 ++
 .../linux-firmware/linux-firmware-20241017.ebuild  | 410 +++++++++++++++++++++
 3 files changed, 447 insertions(+)