Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 941525 - =net-print/hplip-3.24.4 ships broken hp-doctor binary
Summary: =net-print/hplip-3.24.4 ships broken hp-doctor binary
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Daniel Pielmeier
URL: https://bugs.launchpad.net/hplip/+bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-14 11:52 UTC by tt_1
Modified: 2024-12-02 06:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
trivial one line patch from upstream bug (0001-fix-hpdoc.patch,489 bytes, patch)
2024-10-14 11:55 UTC, tt_1
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2024-10-14 11:52:57 UTC
running hp-doctor binary leads to this: 

Checking Permissions....


Checking for Configured Queues....
Traceback (most recent call last):
  File "/usr/bin/hp-doctor", line 328, in <module>
    queues.main_function(dep.core.passwordObj, MODE,ui_toolkit, False, DEVICE_URI)
  File "/usr/share/hplip/base/queues.py", line 338, in main_function
    mapofDevices,status = parseQueues(mode)
                          ^^^^^^^^^^^^^^^^^
  File "/usr/share/hplip/base/queues.py", line 115, in parseQueues
    if device_uri.startswith("cups-pdf:/"):
       ^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'startswith'
Comment 1 tt_1 2024-10-14 11:55:11 UTC
Created attachment 905789 [details, diff]
trivial one line patch from upstream bug

This makes my hp-doctor binary work, it was modeled from comment #2 in the linked bug. Please consider adding it to the patchset.
Comment 2 Larry the Git Cow gentoo-dev 2024-12-01 20:07:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a196101487c4d2a5902ef4bedfb4028e50e0385

commit 8a196101487c4d2a5902ef4bedfb4028e50e0385
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2024-12-01 20:07:05 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2024-12-01 20:07:05 +0000

    net-print/hplip: add 3.24.4-r1
    
    Closes: https://bugs.gentoo.org/941525
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 net-print/hplip/Manifest               |   1 +
 net-print/hplip/hplip-3.24.4-r1.ebuild | 296 +++++++++++++++++++++++++++++++++
 2 files changed, 297 insertions(+)
Comment 3 tt_1 2024-12-02 05:09:52 UTC
thanks for adding the patch to the patchset, however you did:

- added >=dev-python/pyqt5-5.5.1[dbus,gui,widgets,${PYTHON_USEDEP}] to RDEPEND, portage needs the exact name including captions: PyQt5
- add the -r1 ebuild straight to stable - it should be unstable first, and stabilized later?
Comment 4 Daniel Pielmeier gentoo-dev 2024-12-02 06:42:11 UTC
(In reply to tt_1 from comment #3)
> thanks for adding the patch to the patchset, however you did:
> 
> - added >=dev-python/pyqt5-5.5.1[dbus,gui,widgets,${PYTHON_USEDEP}] to
> RDEPEND, portage needs the exact name including captions: PyQt5

Is there a problem with building the package? PyQt5 got renamed to pyqt5 recently. Maybe for some reason you did not get that change.

> - add the -r1 ebuild straight to stable - it should be unstable first, and
> stabilized later?

For such a trivial change I did not mind to commit straight to stable.
Comment 5 tt_1 2024-12-02 06:51:27 UTC
ah thanks, I hadn't synced it yet into my tree. 

for the keyword rollover, it doesn't really matter to me since I had the patch applied via /etc/portage/patches/ for a month now.