Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 941295 - sys-fs/loop-aes build-initrd.sh calling 'losetup' executes the wrong one
Summary: sys-fs/loop-aes build-initrd.sh calling 'losetup' executes the wrong one
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Hank Leininger
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-10-12 01:13 UTC by Hank Leininger
Modified: 2024-11-13 05:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hank Leininger 2024-10-12 01:13:25 UTC
loop-aes expects/is intended to patch losetup and mount from util-linux. But on Gentoo our packaging leaves these alone, instead installs loop-aes-losetup and does not bother with a loop-aes-mount.

Starting with loop-aes-3.7w I added changes to the initrd generation script to
explicitly call losetup and then mount, to work around incompatibilities.

However on an already-installed system where the initrd is rebuilt, this ends up calling the unpatched losetup which does not handle the loop-aes-specific arguments.

Instead, build-initrd.sh needs to check for and prefer loop-aes-losetup if it is present.
Comment 1 Larry the Git Cow gentoo-dev 2024-11-13 05:56:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f168a5fc7f0acef76b0192c8153e0dd58c914272

commit f168a5fc7f0acef76b0192c8153e0dd58c914272
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2024-10-12 01:52:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-13 05:55:29 +0000

    sys-fs/loop-aes: bump; compat improvements
    
    Adds kernel 6.11.x support. Prefer loop-aes-losetup if available;
    support using ext2 instead of minix in the initrd image.
    
    Closes: https://bugs.gentoo.org/941183
    Closes: https://bugs.gentoo.org/941184
    Closes: https://bugs.gentoo.org/941295
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-fs/loop-aes/Manifest                           |  2 +
 .../loop-aes-3.8e-build-initrd_initfstype.patch    | 76 ++++++++++++++++++++
 ...-aes-3.8e-build-initrd_prefer-l-a-losetup.patch | 42 +++++++++++
 sys-fs/loop-aes/loop-aes-3.8e.ebuild               | 84 ++++++++++++++++++++++
 4 files changed, 204 insertions(+)