Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 941285 - dev-util/promu-0.15.0: command failed: build ...promu: exit status 1
Summary: dev-util/promu-0.15.0: command failed: build ...promu: exit status 1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: Normal normal
Assignee: Zac Medico
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-10-11 15:37 UTC by Nuno
Modified: 2024-10-24 19:31 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.txt,6.57 KB, text/plain)
2024-10-11 15:37 UTC, Nuno
Details
build.log (build.log.bz2,38.12 KB, application/x-bzip2)
2024-10-11 15:39 UTC, Nuno
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno 2024-10-11 15:37:34 UTC
note: dev-util/promu-0.17.0 builds without issue

Reproducible: Always

Steps to Reproduce:
emerge -1v '=dev-util/promu-0.15.0::gentoo'
Actual Results:  
...

>> rebuilding binaries using promu
GO111MODULE=on /var/tmp/portage/dev-util/promu-0.15.0/homedir/go/bin/promu build --prefix /var/tmp/portage/dev-util/promu-0.15.0/work/promu-0.15.0
 >   promu-0.15.0
WORK=/var/tmp/portage/dev-util/promu-0.15.0/temp/go-build3525329252
-buildmode=pie requires external (cgo) linking, but cgo is not enabled
!! command failed: build -o /var/tmp/portage/dev-util/promu-0.15.0/work/promu-0.15.0/promu-0.15.0 -ldflags -s -X github.com/prometheus/common/version.Version=0.15.0 -X github.com/prometheus/common/version.Revision=non-git -X github.com/prometheus/common/version.Branch=non-git -X github.com/prometheus/common/version.BuildUser=portage@localhost -X github.com/prometheus/common/version.BuildDate=20241010-17:13:19  -extldflags '-static' -a -tags netgo,static_build github.com/prometheus/promu: exit status 1
make: *** [Makefile:21: build] Error 1
 * ERROR: dev-util/promu-0.15.0::gentoo failed (compile phase):
 *   emake failed
Comment 1 Nuno 2024-10-11 15:37:59 UTC
Created attachment 905181 [details]
emerge --info
Comment 2 Nuno 2024-10-11 15:39:19 UTC
Created attachment 905182 [details]
build.log
Comment 3 Zac Medico gentoo-dev 2024-10-12 23:16:18 UTC
Probably need to disable pie as in bug 917577.
Comment 4 Nuno 2024-10-15 10:44:49 UTC
Thanks. Confirmed promu-0.15.0 builds successfully on arm with this patch:

--- promu-0.15.0.ebuild 2024-01-07 06:41:46.000000000 +0000
+++ promu-0.15.0-r1.ebuild      2024-10-15 11:15:20.885487577 +0100
@@ -35,5 +35,5 @@
 
 src_compile() {
-       if use x86; then
+       if use x86 || use arm; then
                #917577 pie breaks build on x86
                GOFLAGS=${GOFLAGS//-buildmode=pie}


I can make a pull request for this. Is a new revision appropriate in this case?

I'm not sure I understand why promu-0.15.0 failed and promu-0.17.0 didn't?

Thank you
Comment 5 Zac Medico gentoo-dev 2024-10-15 23:12:17 UTC
Yes, please send a PR. It's interesting that promu-0.17.0 did not fail, I would love to understand why.
Comment 6 Zac Medico gentoo-dev 2024-10-15 23:12:52 UTC
No need for revbump.
Comment 7 Larry the Git Cow gentoo-dev 2024-10-24 19:28:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ad6992c77e8c025323940ffceba838726b3f68c

commit 6ad6992c77e8c025323940ffceba838726b3f68c
Author:     Nuno Silva <nuno.m.ribeiro.silva@tecnico.ulisboa.pt>
AuthorDate: 2024-10-23 23:46:19 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2024-10-24 19:27:32 +0000

    dev-util/promu-0.15.0: disable pie on arm
    
    Signed-off-by: Nuno Silva <nuno.m.ribeiro.silva@tecnico.ulisboa.pt>
    Closes: https://bugs.gentoo.org/941285
    Closes: https://github.com/gentoo/gentoo/pull/39093
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 dev-util/promu/promu-0.15.0.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 8 Zac Medico gentoo-dev 2024-10-24 19:31:04 UTC
(In reply to Zac Medico from comment #5)
> Yes, please send a PR. It's interesting that promu-0.17.0 did not fail, I
> would love to understand why.

Probably a cgo thing as in bug 924632.