Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 941235 - [guru] games-arcade/taisei-1.4.2 has implicit function declarations in configure logs
Summary: [guru] games-arcade/taisei-1.4.2 has implicit function declarations in config...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Haelwenn (lanodan) Monnier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2024-10-10 12:12 UTC by Agostino Sarubbo
Modified: 2024-10-11 09:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,898.66 KB, text/plain)
2024-10-10 12:12 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-10-10 12:12:32 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-arcade/taisei-1.4.2 has implicit function declarations in configure logs.
Discovered on: amd64 (internal ref: guru_ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0072
Comment 1 Agostino Sarubbo gentoo-dev 2024-10-10 12:12:34 UTC
Created attachment 905152 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-10-10 12:12:35 UTC
Found the following implicit function declarations in configure logs:

meson-log.txt:2770 - qsort_r
meson-log.txt:2800 - qsort_s
Comment 3 Oliver Freyermuth 2024-10-10 12:26:03 UTC
Hi Haelwenn,

checking on this, it appears to be caused by:
 Checking if "GNU qsort_r()" : links: YES 
 Checking if "BSD qsort_r()" : links: NO 
 Checking if "Microsoft qsort_s()" : links: NO 
i.e. the latter two checks which check existence of the functions by trying to link, i.e. it's an expected part of the checks. 

So I guess we need to add QA_CONFIG_IMPL_DECL_SKIP for those funcs, do you agree / want to do it (I can also add it)? 

Cheers,
Oliver
Comment 4 Haelwenn (lanodan) Monnier 2024-10-10 15:04:03 UTC
Yeah, seems like the right way to do it, went ahead and fixed it while I was looking at it.
Comment 5 Oliver Freyermuth 2024-10-10 15:06:04 UTC
Thanks a lot!
Comment 6 Larry the Git Cow gentoo-dev 2024-10-11 09:55:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=1a0eccdda6bc71d21ca2d8f579c258fdd38e24e0

commit 1a0eccdda6bc71d21ca2d8f579c258fdd38e24e0
Author:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
AuthorDate: 2024-10-10 14:59:26 +0000
Commit:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
CommitDate: 2024-10-10 15:01:15 +0000

    games-arcade/taisei: add QA_CONFIG_IMPL_DECL_SKIP for BSD qsort_r and MS qsort_s
    
    Closes: https://bugs.gentoo.org/941235
    Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>

 games-arcade/taisei/taisei-1.4.2.ebuild | 7 +++++++
 1 file changed, 7 insertions(+)