Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940630 - net-misc/yt-dlp-2024.09.27 fails tests: TypeError: serve() got an unexpected keyword argument 'ssl'
Summary: net-misc/yt-dlp-2024.09.27 fails tests: TypeError: serve() got an unexpected ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ionen Wolkens
URL:
Whiteboard:
Keywords:
Depends on: 941319 945434
Blocks:
  Show dependency tree
 
Reported: 2024-10-02 02:55 UTC by Jonathan Lovelace
Modified: 2025-02-21 15:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-misc:yt-dlp-2024.09.27:20241002-023739.log (net-misc:yt-dlp-2024.09.27:20241002-023739.log,309.46 KB, text/plain)
2024-10-02 02:55 UTC, Jonathan Lovelace
Details
emerge-info.txt (emerge-info.txt,9.37 KB, text/plain)
2024-10-02 02:56 UTC, Jonathan Lovelace
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Lovelace 2024-10-02 02:55:38 UTC
Created attachment 904633 [details]
net-misc:yt-dlp-2024.09.27:20241002-023739.log

=net-misc/yt-dlp-2024.09.27 fails its test phase for me, on this mostly-stable system. Specifically, 34 tests in test/test_websockets.py fail with the error "TypeError: serve() got an unexpected keyword argument 'ssl'". Perhaps the dependency on dev-python/websockets needs to have its lower bound raised?
Comment 1 Jonathan Lovelace 2024-10-02 02:56:06 UTC
Created attachment 904634 [details]
emerge-info.txt
Comment 2 Ionen Wolkens gentoo-dev 2024-10-02 03:31:04 UTC
Seems I missed this given I don't have websockets installed (it's optional).

Arguably not a big deal given I don't think most people need websockets and that's why the ebuild mostly ignores it (not even mentioned as a optfeature). So mostly only an issue for those running tests.

Guess I could add it as hard test? ( ) dependency along other optional deps though, plus the lower bound. Albeit I can't yet given newer websockets is not stable yet.

The regular python workflow will likely stable 13.1 in a week or so, so figure could wait rather than push for it given it's not urgent.
Comment 3 Larry the Git Cow gentoo-dev 2025-02-21 15:36:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4846b48997fd1f77d1a5ebfd1cbbaebd3e3253fe

commit 4846b48997fd1f77d1a5ebfd1cbbaebd3e3253fe
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2025-02-21 15:26:03 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2025-02-21 15:36:09 +0000

    net-misc/yt-dlp: (always) skip websockets tests
    
    These were already skipped when dev-python/websockets is not installed.
    
    In bug #940630, considered depending on it for tests but yt-dlp seems
    to be picky with websockets version (sometime wanting newer, sometime
    older to work right) and that works out poorly with the straight to
    stable model of yt-dlp.
    
    Ultimately not aware of typical users needing this, we do not even
    advertise it as a optfeature -- so can consider it semi-unsupported.
    
    Closes: https://bugs.gentoo.org/940630
    Closes: https://bugs.gentoo.org/950030
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 net-misc/yt-dlp/yt-dlp-2025.02.19.ebuild | 8 ++++----
 net-misc/yt-dlp/yt-dlp-9999.ebuild       | 4 ++++
 2 files changed, 8 insertions(+), 4 deletions(-)