Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940501 - multilib.eclass: add get_abi_CXXFLAGS
Summary: multilib.eclass: add get_abi_CXXFLAGS
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-30 01:18 UTC by Sam James
Modified: 2024-09-30 16:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-09-30 01:18:29 UTC
We should have get_abi_CXXFLAGS for parity in multilib.eclass.
Comment 1 Larry the Git Cow gentoo-dev 2024-09-30 01:52:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a9156e205ca667cf40f43329b5bc22749f166501

commit a9156e205ca667cf40f43329b5bc22749f166501
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-09-30 01:19:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-09-30 01:51:42 +0000

    toolchain.eclass: pass STAGE1_CXXFLAGS
    
    Note that we're reusing get_abi_CFLAGS here as multilib.eclass doesn't
    have get_abi_CXXFLAGS yet (bug #940501).
    
    Adding this for the benefit of some GDC hackery we're doing (bug #940470).
    
    Bug: https://bugs.gentoo.org/940501
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/toolchain.eclass | 3 +++
 1 file changed, 3 insertions(+)
Comment 2 Mike Gilbert gentoo-dev 2024-09-30 16:37:59 UTC
get_abi_CFLAGS just returns the value of CFLAGS_${ABI} as set in profiles.

CFLAGS_${ABI} contains language agnostic options like "-m32" or "-mabi=32".

I don't really see any reason to introduce a CXXFLAGS_${ABI} variable to profiles.  How would it be populated differently from CFLAGS_${ABI}?