Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940272 - dev-libs/jsoncpp-1.9.6: regression with meson build (check_required_components)
Summary: dev-libs/jsoncpp-1.9.6: regression with meson build (check_required_components)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michał Górny
URL: https://github.com/open-source-parser...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 939604
  Show dependency tree
 
Reported: 2024-09-26 15:31 UTC by Haelwenn (lanodan) Monnier
Modified: 2024-10-16 20:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Haelwenn (lanodan) Monnier 2024-09-26 15:31:05 UTC 
See https://github.com/open-source-parsers/jsoncpp/issues/1568 and https://bugs.gentoo.org/940262

Which seems to be due to meson version lacking jsoncpp-targets.cmake or equivalent to define `JsonCpp` when the target is `JsonCpp` rather than `JsonCpp::JsonCpp`.
Comment 1 Eli Schwartz gentoo-dev 2024-09-26 17:02:12 UTC 
The real bug is here:

https://github.com/KhronosGroup/OpenXR-SDK/blob/7d1c0961351bac61fd7bb72d402649d5ac3f2935/src/cmake/FindJsonCpp.cmake#L274-L279

It considers pkgconfig to be "old-school"...

Fallout from the original addition in https://github.com/open-source-parsers/jsoncpp/pull/1486 which I guess was flawed? So now stuff can find this cmake file and fail due to finding it...
Comment 2 Eli Schwartz gentoo-dev 2024-09-26 17:03:10 UTC 
Proposed fix has been submitted: remove check_required_components altogether.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-09-29 10:40:31 UTC 
We should pull in the patch now.
Comment 4 Larry the Git Cow gentoo-dev 2024-09-29 10:50:01 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09cbba1a603ba17efa14e163c3443ef6231eec1f

commit 09cbba1a603ba17efa14e163c3443ef6231eec1f
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-09-29 10:48:35 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-09-29 10:48:35 +0000

    dev-libs/jsoncpp: Fix installed CMake files
    
    Closes: https://bugs.gentoo.org/940272
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-libs/jsoncpp/files/jsoncpp-1.9.6-cmake.patch | 21 +++++++++
 dev-libs/jsoncpp/jsoncpp-1.9.6-r1.ebuild         | 56 ++++++++++++++++++++++++
 2 files changed, 77 insertions(+)
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-09-29 10:50:13 UTC 
Once you confirm that -r1 works, let's stabilize it.
Comment 6 Haelwenn (lanodan) Monnier 2024-09-30 06:38:14 UTC 
Thanks, -r1 works!