Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940259 - sci-geosciences/josm-bin desktop entry should be improved
Summary: sci-geosciences/josm-bin desktop entry should be improved
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Henning Schild
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-09-26 10:36 UTC by Henning Schild
Modified: 2024-09-27 05:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henning Schild 2024-09-26 10:36:01 UTC
The ebuilds do generate an entry with "make_desktop_entry". That used to work well but also has some limitations.

i.e. it lacks support for mime-types and opening files with josm directly

The desktop entry shipped by upstream in their debian packages supports mime types.

Also with version 19160 on plasma6 there is no menu entry anymore. Must be some field missing or having a value plasma6 does not like.

The easiest will likely be to find the source of the upstream desktop entry and include it instead of crafting our own.

Reproducible: Always
Comment 1 Henning Schild 2024-09-26 10:48:03 UTC
Turns out there was a menu entry on plasma6. But the menu search did not find it any longer when starting to type "josm", only as "java" which is what "Name" starts with.

The minimal fix for that would be to

Name=JOSM
GenericName=Java OpenStreetMap Editor

as seen in those debian packages
Comment 2 Larry the Git Cow gentoo-dev 2024-09-27 05:57:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=382d508259d8d87de085f1fe242b3ec7b7b680e2

commit 382d508259d8d87de085f1fe242b3ec7b7b680e2
Author:     Henning Schild <henning@hennsch.de>
AuthorDate: 2024-09-26 11:56:00 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-09-27 05:55:42 +0000

    sci-geosciences/josm-bin: switch to upstream desktop file and add mime
    
    The desktop entry from upstream is much more elaborate and offers more
    features to users. Use it and the mime-type definitions but keep
    changing the name from "josm" to "josm-bin" where needed.
    
    Closes: https://bugs.gentoo.org/940259
    Signed-off-by: Henning Schild <henning@hennsch.de>
    Closes: https://github.com/gentoo/gentoo/pull/38778
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 sci-geosciences/josm-bin/Manifest                 |  2 +
 sci-geosciences/josm-bin/josm-bin-19207-r1.ebuild | 57 +++++++++++++++++++++++
 2 files changed, 59 insertions(+)