I play around with some wayland-ready xfce packages on my wayland-only device. The xfce-base/xfdesktop-4.19.3 fails to build. Reproducible: Always Steps to Reproduce: 1. emerge -va1 xfce-base/xfdesktop # FEATURES="-distcc" emerge --info xfce-base/xfdesktop Portage 3.0.65 (python 3.12.6-final-0, default/linux/amd64/23.0/desktop, gcc-13, glibc-2.39-r6, 6.6.47-gentoo-dist x86_64) ================================================================= System Settings ================================================================= System uname: Linux-6.6.47-gentoo-dist-x86_64-Intel-R-_Core-TM-_i5-5250U_CPU_@_1.60GHz-with-glibc2.39 KiB Mem: 8030700 total, 1648200 free KiB Swap: 8388604 total, 8388604 free Timestamp of repository gentoo: Sat, 21 Sep 2024 08:00:00 +0000 Head commit of repository gentoo: c58c58b9ecafaa51c3449184132fa698ee23e761 Head commit of repository bell07: 16963dc386c11bf264ffa2895e230a773151c2ef Timestamp of repository guru: Fri, 20 Sep 2024 19:33:51 +0000 Head commit of repository guru: 6480911e0ac24d96b9b58e79a40f8e7b3d98e05d Timestamp of repository steam-overlay: Sun, 08 Sep 2024 18:36:43 +0000 Head commit of repository steam-overlay: 9e11573f22a5ab039769afea81b31ccd89af454e sh bash 5.2_p26-r6 ld GNU ld (Gentoo 2.42 p3) 2.42.0 distcc 3.4 x86_64-pc-linux-gnu [disabled] app-misc/pax-utils: 1.3.7::gentoo app-shells/bash: 5.2_p26-r6::gentoo dev-build/autoconf: 2.71-r7::gentoo dev-build/automake: 1.16.5-r2::gentoo dev-build/cmake: 3.30.2::gentoo dev-build/libtool: 2.4.7-r4::gentoo dev-build/make: 4.4.1-r1::gentoo dev-build/meson: 1.5.1::gentoo dev-java/java-config: 2.3.4::gentoo dev-lang/perl: 5.40.0::gentoo dev-lang/python: 3.12.6_p2::gentoo sys-apps/baselayout: 2.15::gentoo sys-apps/openrc: 0.54.2::gentoo sys-apps/sandbox: 2.39::gentoo sys-devel/binutils: 2.42-r1::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/clang: 18.1.8::gentoo sys-devel/gcc: 13.3.1_p20240614::gentoo sys-devel/gcc-config: 2.11::gentoo sys-devel/llvm: 18.1.8-r1::gentoo sys-kernel/linux-headers: 6.6-r1::gentoo (virtual/os-headers) sys-libs/glibc: 2.39-r6::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 volatile: False sync-rsync-verify-metamanifest: yes sync-rsync-verify-jobs: 1 sync-rsync-extra-opts: sync-rsync-verify-max-age: 3 bell07 location: /var/db/repos/bell07 sync-type: git sync-uri: https://github.com/bell07/gentoo-bell07_overlay.git masters: gentoo volatile: False guru location: /var/db/repos/guru sync-type: git sync-uri: https://github.com/gentoo-mirror/guru.git masters: gentoo volatile: False steam-overlay location: /var/db/repos/steam-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/steam-overlay.git masters: gentoo volatile: False Binary Repositories: binhost priority: 9999 sync-uri: https://ftp.uni-hannover.de/gentoo/releases/amd64/binpackages/23.0/x86-64-v3 Installed sets: @my-local ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -march=broadwell -mabm -maes --param=l1-cache-line-size=64 --param=l1-cache-size=32 --param=l2-cache-size=3072" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d" CXXFLAGS="-O2 -pipe -march=broadwell -mabm -maes --param=l1-cache-line-size=64 --param=l1-cache-size=32 --param=l2-cache-size=3072" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS=" --autounmask --autounmask-write n --autounmask-backtrack y --binpkg-respect-use=y" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O2 -pipe -march=broadwell -mabm -maes --param=l1-cache-line-size=64 --param=l1-cache-size=32 --param=l2-cache-size=3072" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance binpkg-request-signature buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles getbinpkg ipc-sandbox merge-sync merge-wait multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe -march=broadwell -mabm -maes --param=l1-cache-line-size=64 --param=l1-cache-size=32 --param=l2-cache-size=3072" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="de_DE" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs" LEX="flex" MAKEOPTS="-j6" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/bash" USE="a52 aac aacs acl acpi alsa amd64 appindicator bdplus bluetooth bluray branding bzip2 cacert cairo cdda cddb cet cover crypt css dbus dist-kernel dri dts dvd dvdr egl elogind encode exif fat ffmpeg flac fluidsynth gamepad gdbm gdk-pixbuf gif gimp git gles2 gpm gstreamer gtk gtk3 gtk4 gui hddtemp heif hfs iconv icu ipv6 java joystick jpeg jpeg2k kf6compat lcms libnotify libtirpc lm-sensors logrotate lto mad midi mms mng mp3 mp4 mpeg mtp multilib ncurses networkmanager nls ntfs oauth-gtk4 ocr ogg opencv openexr opengl openmp openrc opus pam pango pcre pdf pgo pipewire png policykit postscript ppds printsupport pulseaudio qml qt6 readline rtmp samba scanner sdl seccomp snmp sound spell sqlite ssl startup-notification svg sysv-utils test-rust theora threads tiff truetype udev udf udisks unicode upower usb v4l vaapi vorbis vpx vulkan wayland webp widevine widgets wiimote wmf wxwidgets x264 x265 xattr xcb xft xml xpmopenexr xv xvid xwayland zeroconf zlib" ABI_X86="32 64" ADA_TARGET="gcc_12" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GUILE_SINGLE_TARGET="3-0" GUILE_TARGETS="3-0" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en de" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-2" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_12" PYTHON_TARGETS="python3_12" RUBY_TARGETS="ruby31 ruby32" SANE_BACKENDS="hp net" VIDEO_CARDS="i915 intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS ================================================================= Package Settings ================================================================= xfce-base/xfdesktop-4.19.2_p20240509::gentoo was built with the following: USE="libnotify thunar wayland -X" ABI_X86="(64)" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance binpkg-request-signature buildpkg-live config-protect-if-modified distcc distlocks ebuild-locks fixlafiles getbinpkg ipc-sandbox merge-sync merge-wait multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
Created attachment 903494 [details] build.log
I can't reproduce, and I have no clue how this could happen. The include chain looks correct, and xfdesktop-application.c definitely does include libxfce4ui.h.
# fgrep -R XfceSMClient /usr/include/ /usr/include/xfce4/libxfce4ui-2/libxfce4ui/libxfce4ui-enums.h:} XfceSMClientRestartStyle; /usr/include/xfce4/libxfce4ui-2/libxfce4ui/libxfce4ui-enums.h:} XfceSMClientPriority; /usr/include/xfce4/libxfce4ui-2/libxfce4ui/libxfce4ui-enums.h:} XfceSMClientShutdownHint; # fgrep -R XfceSMClient /var/tmp/portage/xfce-base/xfdesktop-4.19.3/work/ /var/tmp/portage/xfce-base/xfdesktop-4.19.3/work/xfdesktop-4.19.3/src/xfdesktop-application.c: XfceSMClient *sm_client; /var/tmp/portage/xfce-base/xfdesktop-4.19.3/work/xfdesktop-4.19.3/src/xfdesktop-application.c: XfceSMClient *sm_client; Which file provide the XfceSMClient type? I cannot find it in my system
New finding: If I recompile xfce-base/libxfce4ui with USE=X enabled, I am able to build xfce-base/xfdesktop If I recompile xfce-base/libxfce4ui with USE=-X the build xfce-base/xfdesktop fails. In this constellation I am not able to rebuild xfce-base/xfdesktop: xfce-base/libxfce4ui-4.19.7::gentoo was built with the following: USE="introspection startup-notification wayland -X -glade -system-info -vala" ABI_X86="(64)" xfce-base/xfdesktop-4.19.7::gentoo was built with the following: USE="libnotify thunar wayland -X" ABI_X86="(64)"
Created attachment 913422 [details] New build log for 4.19.7 I see the error message is changed. I do not know if it is the same error or the previous error is solved and a new error appears... new build.log attached
(In reply to Michał Górny from comment #2) > I can't reproduce, and I have no clue how this could happen. The include > chain looks correct, and xfdesktop-application.c definitely does include > libxfce4ui.h. I can reproduce this whenever USE=X ist forced upon xfdesktop and USE=-X on libxfce5ui. (at least with 4.20) >=xfce-base/libxfce4ui-4.18.0:= That looks incomplete to me, since xfdesktop with USE=X requires libxfceui4 with USE=X. Besides that particular problem, xfdesktop's configure fails to properly check on this - however, that's more of an upstream issue.
(In reply to Alexander Weber from comment #5) > Created attachment 913422 [details] > New build log for 4.19.7 > > I see the error message is changed. > I do not know if it is the same error or the previous error is solved and a > new error appears... > > new build.log attached I can second that oen too. main.c: In function ‘main’: main.c:62:56: error: implicit declaration of function ‘xfce_sm_client_get_option_group’ [-Wimplicit-function-declaration] 62 | g_application_add_option_group(G_APPLICATION(app), xfce_sm_client_get_option_group(argc, argv)); Regarding this, xfce-sm-client.h is only provided if libfce4ui is compiled with USE="X", same holds true for the acatual function xfce_sm_client_get_option_group, for obvious reasons. So basically the call needs to be conditional on the X support in libxfce4ui.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71d5aed0de179c518b4f4ffb3a364e4ef1add760 commit 71d5aed0de179c518b4f4ffb3a364e4ef1add760 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2025-01-04 14:50:54 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2025-01-04 14:59:16 +0000 xfce-base/xfdesktop: Require libxfce4ui[X?] Closes: https://bugs.gentoo.org/939993 Signed-off-by: Michał Górny <mgorny@gentoo.org> xfce-base/xfdesktop/xfdesktop-4.20.0.ebuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
This fixes the second compilation issue, however untested, because xfwm has some issues aswell. diff '--color=auto' -Naur xfdesktop-4.20.0-orig/src/main.c xfdesktop-4.20.0-new/src/main.c --- xfdesktop-4.20.0-orig/src/main.c 2024-11-04 17:35:32.000000000 +0100 +++ xfdesktop-4.20.0-new/src/main.c 2025-01-04 15:49:02.439285917 +0100 @@ -59,7 +59,9 @@ #endif app = xfdesktop_application_get(); +#ifdef ENABLE_X11 g_application_add_option_group(G_APPLICATION(app), xfce_sm_client_get_option_group(argc, argv)); +#endif ret = g_application_run(G_APPLICATION(app), argc, argv);
Issue still not fixed. xfce-base/xfdesktop-4.20.0 still cannot be built, if USE="-X" is set in make.conf
Confirm the patch solves the issue, provided by Sven E.
(In reply to Sven E. from comment #9) > This fixes the second compilation issue, however untested, because xfwm has > some issues aswell. > > diff '--color=auto' -Naur xfdesktop-4.20.0-orig/src/main.c > xfdesktop-4.20.0-new/src/main.c > --- xfdesktop-4.20.0-orig/src/main.c 2024-11-04 17:35:32.000000000 +0100 > +++ xfdesktop-4.20.0-new/src/main.c 2025-01-04 15:49:02.439285917 +0100 > @@ -59,7 +59,9 @@ > #endif > > app = xfdesktop_application_get(); > +#ifdef ENABLE_X11 > g_application_add_option_group(G_APPLICATION(app), > xfce_sm_client_get_option_group(argc, argv)); > +#endif > > ret = g_application_run(G_APPLICATION(app), argc, argv); Please send the patch upstream.
Issue can be closed. xfce-base/xfdesktop-4.20.1 does build as expected without any patch.
