939943 – media-sound/mpd-0.23.15-r1 die: command not found in openrc init script

Bug 939943 - media-sound/mpd-0.23.15-r1 die: command not found in openrc init script

Summary: media-sound/mpd-0.23.15-r1 die: command not found in openrc init script

Status:	UNCONFIRMED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Adrian Schollmeyer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2024-09-21 05:15 UTC by Alix
Modified:	2024-09-24 01:16 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
possible init script patch (mpd.patch,1.03 KB, patch) 2024-09-21 05:17 UTC, Alix	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alix 2024-09-21 05:15:20 UTC

Openrc init script references die function in check_config() to guard against misconfiguration. Logic doesn't work as die function is not defined and no such command exist. 

And since init script errors don't stop script execution for some reason, service starts anyway.

Reproducible: Always

Steps to Reproduce:
1. Don't define group in /etc/mpd.conf
2. /etc/init.d/mpd start
Actual Results:  
# /etc/init.d/mpd start
/etc/init.d/mpd: line 40: die: command not found
 * Starting mpd ...                                                  [ ok ]

Expected Results:  
# /etc/init.d/mpd start
 * Checking mpd configuration ...
 * group must be set in /etc/mpd.conf!
 * failed, please correct errors above                              [ !! ]
 * ERROR: mpd failed to start

Comment 1 Alix 2024-09-21 05:17:22 UTC

Created attachment 903483 [details, diff]
possible init script patch