Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 939807 - dev-libs/libixion-0.19.0: sci-visualization/labplot-2.11.1[ods] fails to build with /usr/include/libixion-0.18/ixion/env.hpp:39:5: error: "_WIN32" is not defined, evaluates to 0 [-Werror=undef]
Summary: dev-libs/libixion-0.19.0: sci-visualization/labplot-2.11.1[ods] fails to buil...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Office Team
URL: https://gitlab.com/ixion/ixion/-/merg...
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks:
 
Reported: 2024-09-18 07:38 UTC by Oliver Freyermuth
Modified: 2024-09-20 21:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge --info (emerge-info.txt,16.79 KB, text/plain)
2024-09-18 07:39 UTC, Oliver Freyermuth 		Details
Full build log (sci-visualization:labplot-2.11.1:20240918-073117.log.gz,55.46 KB, application/gzip)
2024-09-18 07:39 UTC, Oliver Freyermuth 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Freyermuth 2024-09-18 07:38:06 UTC 
Labplot fails to compile with USE=ods, build log excerpt:

.../labplot-2.11.1/src/backend/datasources/filters/OdsFilter.cpp                                                                                                                                                                                                                                               
In file included from /usr/include/libixion-0.18/ixion/types.hpp:11,                                                                                                                                                                                                                                        
                 from /usr/include/libixion-0.18/ixion/address.hpp:11,                                                                                                                                                                                                                                      
                 from /usr/include/liborcus-0.18/orcus/spreadsheet/sheet.hpp:17,                                                                                                                                                                                                                            
                 from /var/tmp/portage/sci-visualization/labplot-2.11.1/work/labplot-2.11.1/src/backend/datasources/filters/OdsFilter.cpp:23:                                                                                                                                                               
/usr/include/libixion-0.18/ixion/env.hpp:39:5: error: "_WIN32" is not defined, evaluates to 0 [-Werror=undef]                                                                                                                                                                                               
   39 | #if _WIN32
      |     ^~~~~~


Reproducible: Always

Steps to Reproduce:
1. USE="ods" emerge =labplot.2.11.1


Actual Results:  
Build fails.

Expected Results:  
Build should work.
Comment 1 Oliver Freyermuth 2024-09-18 07:39:01 UTC 
Created attachment 903247 [details]
emerge --info
Comment 2 Oliver Freyermuth 2024-09-18 07:39:25 UTC 
Created attachment 903248 [details]
Full build log
Comment 3 Andreas Sturmlechner gentoo-dev 2024-09-20 20:46:51 UTC 
Appears to be this fix for libixion:

https://gitlab.com/ixion/ixion/-/commit/7b1df6fc2b989d8a64edaa47fe04edea95c45174
Comment 4 Andreas Sturmlechner gentoo-dev 2024-09-20 20:59:24 UTC 
Hilariously, after fixing this one, labplot fails right again.
Comment 5 Larry the Git Cow gentoo-dev 2024-09-20 21:01:35 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c40d63dfb6d7020445d1bb1494efacfafaf33e32

commit c40d63dfb6d7020445d1bb1494efacfafaf33e32
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-09-20 20:51:03 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-09-20 21:01:26 +0000

    dev-libs/libixion: Fix "_WIN32" is not defined in header
    
    Fixes revdeps like sci-visualization/labplot[ods]
    
    Closes: https://bugs.gentoo.org/939807
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/libixion-0.19.0-fix-win32-ifdef.patch    | 25 +++++++++
 dev-libs/libixion/libixion-0.19.0-r1.ebuild        | 62 ++++++++++++++++++++++
 2 files changed, 87 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd2e586412d2630b39df98988357fc7baa88c995

commit cd2e586412d2630b39df98988357fc7baa88c995
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-09-20 21:00:49 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-09-20 21:01:26 +0000

    sci-visualization/labplot: Fix build with USE=ods
    
    Bug: https://bugs.gentoo.org/939807
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/labplot-2.11.1-ods-buildfix.patch        | 38 ++++++++++++++++++++++
 sci-visualization/labplot/labplot-2.11.1.ebuild    |  2 ++
 2 files changed, 40 insertions(+)