Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 939799 - dev-scheme/guile-3.0.10-r100: QA concerns: there are files installed outside the prefix
Summary: dev-scheme/guile-3.0.10-r100: QA concerns: there are files installed outside ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All OS X
: Normal normal
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-18 01:06 UTC by Ryan Tsien
Modified: 2025-02-24 00:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
A working patch for guile-3.0.10-r100.ebuild (guile-3.0.10-r100.ebuild.diff,1.14 KB, patch)
2024-09-18 02:57 UTC, Ryan Tsien
Details | Diff
outputs of `equeay f guile` (guile.files.txt,49.36 KB, text/plain)
2024-09-18 23:37 UTC, Ryan Tsien
Details
The diff for unprefixed guile installs with the above patch (unprefixed-guile.diff,40.61 KB, patch)
2024-09-19 00:13 UTC, Ryan Tsien
Details | Diff
0001-dev-scheme-guile-fix-installation-of-slotted-guile-o.patch (0001-dev-scheme-guile-fix-installation-of-slotted-guile-o.patch,1.21 KB, patch)
2024-09-19 13:57 UTC, Arsen Arsenović
Details | Diff
files-list-with-0001-dev-scheme-guile-fix-installation-of-slotted-guile-o.patch (guile.files-1.txt,43.47 KB, text/plain)
2024-09-19 14:19 UTC, Ryan Tsien
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Tsien 2024-09-18 01:06:41 UTC
* QA Notice: the following files are outside of the prefix:
 * /usr
 * /usr/share
 * /usr/share/guile-data
 * /usr/share/guile-data/3.0
 * /usr/share/guile-data/3.0/pkgconfig
 * /usr/share/guile-data/3.0/pkgconfig/guile-3.0.pc
 * /usr/share/guile-data/3.0/info
 * /usr/share/guile-data/3.0/info/guile.info
 * /usr/share/guile-data/3.0/info/guile.info-10
 * /usr/share/guile-data/3.0/info/guile.info-11
 * /usr/share/guile-data/3.0/info/guile.info-1
 * /usr/share/guile-data/3.0/info/guile.info-6
 * /usr/share/guile-data/3.0/info/guile.info-8
 * /usr/share/guile-data/3.0/info/guile.info-9
 * /usr/share/guile-data/3.0/info/guile.info-7
 * /usr/share/guile-data/3.0/info/dir
 * /usr/share/guile-data/3.0/info/r5rs.info
 * /usr/share/guile-data/3.0/info/guile.info-5
 * /usr/share/guile-data/3.0/info/guile.info-2
 * /usr/share/guile-data/3.0/info/guile.info-3
 * /usr/share/guile-data/3.0/info/guile.info-4
 * ERROR: dev-scheme/guile-3.0.10-r100::gentoo_prefix failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix

maybe a "$PREFIX" should be inserted before:
> 46 GUILE_PCDIR="/usr/share/guile-data/${SLOT}/pkgconfig"


Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-09-18 01:19:26 UTC
Thank you for testing slotted guile!
Comment 2 Ryan Tsien 2024-09-18 02:57:25 UTC
Created attachment 903242 [details, diff]
A working patch for guile-3.0.10-r100.ebuild
Comment 3 Arsen Arsenović gentoo-dev 2024-09-18 16:43:45 UTC
hmm, why remove:

	mv "${ED}"/usr/share/aclocal/guile{,-"${SLOT}"}.m4 || die

... also, what's the diff of installed files on an unprefixed system?
Comment 4 Ryan Tsien 2024-09-18 23:35:18 UTC
> hmm, why remove:
>	mv "${ED}"/usr/share/aclocal/guile{,-"${SLOT}"}.m4 || die

because the guile.m4 is installed at:

$EPREFIX/usr/share/guile-data/3.0/aclocal/guile.m4
Comment 5 Ryan Tsien 2024-09-18 23:37:03 UTC
Created attachment 903298 [details]
outputs of `equeay f guile`

> ... also, what's the diff of installed files on an unprefixed system?
Comment 6 Arsen Arsenović gentoo-dev 2024-09-19 00:04:39 UTC
(In reply to Ryan Tsien from comment #4)
> > hmm, why remove:
> >	mv "${ED}"/usr/share/aclocal/guile{,-"${SLOT}"}.m4 || die
> 
> because the guile.m4 is installed at:
> 
> $EPREFIX/usr/share/guile-data/3.0/aclocal/guile.m4

this is outside the aclocal search path, though (which is why I had the old version installed into /usr/share/aclocal)
Comment 7 Ryan Tsien 2024-09-19 00:13:38 UTC
Created attachment 903299 [details, diff]
The diff for unprefixed guile installs with the above patch

> ... also, what's the diff of installed files on an unprefixed system?
Comment 8 Ryan Tsien 2024-09-19 00:21:25 UTC
(In reply to Arsen Arsenović from comment #6)
> (In reply to Ryan Tsien from comment #4)
> > > hmm, why remove:
> > >	mv "${ED}"/usr/share/aclocal/guile{,-"${SLOT}"}.m4 || die
> > 
> > because the guile.m4 is installed at:
> > 
> > $EPREFIX/usr/share/guile-data/3.0/aclocal/guile.m4
> 
> this is outside the aclocal search path, though (which is why I had the old
> version installed into /usr/share/aclocal)

How about just moving this file out?

> mv "${ED}/usr/share/guile-data/${SLOT}/aclocal/guile.m4" "${ED}/usr/share/aclocal/guile-${SLOT}.m4" || die
Comment 9 Arsen Arsenović gentoo-dev 2024-09-19 13:57:52 UTC
Created attachment 903345 [details, diff]
0001-dev-scheme-guile-fix-installation-of-slotted-guile-o.patch

could you test this patch?  don't have prefix set up right now
Comment 10 Ryan Tsien 2024-09-19 14:19:30 UTC
Created attachment 903346 [details]
files-list-with-0001-dev-scheme-guile-fix-installation-of-slotted-guile-o.patch

> could you test this patch?  don't have prefix set up right now

Yes, it works, this is the files list.
Comment 11 Larry the Git Cow gentoo-dev 2024-09-19 18:19:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e75fe9497d0c026b0e09a63241dc3d2d89f1e419

commit e75fe9497d0c026b0e09a63241dc3d2d89f1e419
Author:     Arsen Arsenović <arsen@gentoo.org>
AuthorDate: 2024-09-19 13:54:03 +0000
Commit:     Arsen Arsenović <arsen@gentoo.org>
CommitDate: 2024-09-19 18:14:57 +0000

    dev-scheme/guile: fix installation of slotted guile on prefix
    
    Closes: https://bugs.gentoo.org/939799
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>

 dev-scheme/guile/guile-3.0.10-r100.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)