Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 939791 - media-gfx/freecad-0.21.2-r2 consider using edos2unix.eclass
Summary: media-gfx/freecad-0.21.2-r2 consider using edos2unix.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Paul Zander
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-17 20:09 UTC by Esteve Varela Colominas
Modified: 2024-11-24 20:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Esteve Varela Colominas 2024-09-17 20:09:53 UTC
Right now media-gfx/freecad is one of the few ebuilds that uses dos2unix rather than edos2unix.eclass. Since dos2unix is used in a "find" command, one would have to capture the "find" output into a bash array, and pass that to edos2unix. Alternatively, one can simply replace the "dos2unix" command in the current "find", with the sed one-liner used in edos2unix.
Comment 1 Chris Mayo 2024-10-18 19:06:34 UTC
Or just remove the use of dos2unix, which makes it hard to use patches that are  submitted upstream.

https://github.com/gentoo/gentoo/pull/39021

And changes a lot of files - why is this being done? Could it be more targeted?
Comment 2 Larry the Git Cow gentoo-dev 2024-11-24 20:25:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4441effb71a9457ea25cef1006500c8c71e9757b

commit 4441effb71a9457ea25cef1006500c8c71e9757b
Author:     Chris Mayo <aklhfex@gmail.com>
AuthorDate: 2024-10-29 19:57:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-24 20:24:22 +0000

    media-gfx/freecad: Stop converting line endings
    
    Closes: https://bugs.gentoo.org/939791
    Signed-off-by: Chris Mayo <aklhfex@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 ...freecad-1.0.0-r1-Gentoo-specific-don-t-check-vcs.patch | 15 +++++++++++++++
 media-gfx/freecad/freecad-1.0.0-r1.ebuild                 |  5 +----
 2 files changed, 16 insertions(+), 4 deletions(-)