Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 939202 - app-backup/amanda: broken by perl 5.40
Summary: app-backup/amanda: broken by perl 5.40
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2024-09-07 03:39 UTC by Tim Buchheim
Modified: 2024-12-04 18:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to make Amanda 3.5.4 work with perl 5.40 (amanda-3.5.4-patch-for-perl-5.40.patch,752 bytes, patch)
2024-09-07 03:39 UTC, Tim Buchheim
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buchheim 2024-09-07 03:39:45 UTC
Created attachment 902259 [details, diff]
patch to make Amanda 3.5.4 work with perl 5.40

Perl 5.40 makes a few breaking changes and Amanda needs to be patched to work with it.

I've run across two bugs so far (one a fatal error, the other just a warning) but I wouldn't be surprised if there are more waiting in parts of Amanda I haven't used yet since updating perl on my system.

I've reported the bugs I've found upstream. Details of the two bugs I've found are listed there:  https://github.com/zmanda/amanda/issues/262

Hopefully the Amanda maintainers will release an updated version to work with the newer version of perl.

For now I've patched my copy of Amanda 3.64 to make it run. I haven't looked at 3.5.1 but I imagine the same patch is likely to work.

I've attached a copy of my patch. I'll upload additional patches if I find anything else that needs fixing.
Comment 1 Larry the Git Cow gentoo-dev 2024-12-04 18:24:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c744889ddef99cd36b57ea52b0986de1dcc45dba

commit c744889ddef99cd36b57ea52b0986de1dcc45dba
Author:     Doug Nazar <nazard@nazar.ca>
AuthorDate: 2024-10-25 04:35:22 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-12-04 18:24:05 +0000

    app-backup/amanda: Misc fixes
    
    Fix GCC 14 compilation (-Wincompatible-pointer-types)
    Fix Perl warnings (removed unneeded use statements)
    Fix Perl 5.40 invocation of finished_cb (Tim Buchheim)
    Fix QA warning about using NULL variable
    Fix ndmp requires rpcgen
    
    Signed-off-by: Doug Nazar <nazard@nazar.ca>
    Closes: https://bugs.gentoo.org/933742
    Closes: https://bugs.gentoo.org/939202
    Closes: https://bugs.gentoo.org/933756
    Closes: https://github.com/gentoo/gentoo/pull/39104
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-backup/amanda/amanda-3.5.4-r1.ebuild           | 529 +++++++++++++++++++++
 .../files/amanda-3.5.4-const-whitelist-var.patch   |  21 +
 .../amanda-3.5.4-fix-finished_cb-invocation.patch  |  12 +
 .../amanda-3.5.4-fix-tapelist-null-usage.patch     |  12 +
 ...-3.5.4-remove-amanda-message-severity-use.patch |  22 +
 5 files changed, 596 insertions(+)