Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 939104 - net-analyzer/munin installs invalid logrotate config
Summary: net-analyzer/munin installs invalid logrotate config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sysadmin Bugs
URL:
Whiteboard:
Keywords:
: 939370 (view as bug list)
Depends on: 939408
Blocks:
  Show dependency tree
 
Reported: 2024-09-05 09:34 UTC by Hanno Böck
Modified: 2024-09-13 05:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2024-09-05 09:34:51 UTC
The munin package installs a logrotate config to
/etc/logrotate.d/munin
with the following line:

	create 640 munin

I believe this is invalid, and logrotate complains about it:
error: munin:32 unknown user '640'
error: found error in /var/log/munin/munin-cgi-graph.log /var/log/munin/munin-cgi-html.log, skipping
error: found error in file munin, skipping

According to logrotate's man page
https://linux.die.net/man/8/logrotate
the create command needs three parameters ("mode owner group"), group is not optional.

This happens both with net-analyzer/munin-2.0.75 (stable version) and net-analyzer/munin-2.0.76-r1 (unstable).
Comment 1 Hans de Graaff gentoo-dev Security 2024-09-08 07:31:28 UTC
The two-argument version of create is also valid logrotate, but in that case it assumes owner and group. This explains the error about the unknown user.

I'll add the "root" group here to fix this, consistent with the create statement for the munin-node.log file.
Comment 2 Larry the Git Cow gentoo-dev 2024-09-08 07:31:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e7e40556dc04e37a5787a12e65df13e1e9f4535

commit 8e7e40556dc04e37a5787a12e65df13e1e9f4535
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2024-09-08 07:30:23 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2024-09-08 07:31:44 +0000

    net-analyzer/munin: fix logrotate file
    
    Closes: https://bugs.gentoo.org/939104
    Signed-off-by: Hans de Graaff <graaff@gentoo.org>

 net-analyzer/munin/files/logrotate.d-munin.4 |  33 +++
 net-analyzer/munin/munin-2.0.76-r2.ebuild    | 418 +++++++++++++++++++++++++++
 2 files changed, 451 insertions(+)
Comment 3 Hans de Graaff gentoo-dev Security 2024-09-10 06:04:06 UTC
*** Bug 939370 has been marked as a duplicate of this bug. ***
Comment 4 Hans de Graaff gentoo-dev Security 2024-09-10 06:05:29 UTC
Re-opening until we have a stable version fixed.