Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 938928 - app-portage/kuroo: bogus RDEPEND on kde-apps/kompare:5, missing RDEPEND on kde-misc/kdiff3:*?
Summary: app-portage/kuroo: bogus RDEPEND on kde-apps/kompare:5, missing RDEPEND on kd...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-02 12:36 UTC by Andreas Sturmlechner
Modified: 2024-11-12 16:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2024-09-02 12:36:28 UTC
This is blocking cleanup of kde-apps/kompare:5 and kde-apps/libkomparediff2:5 right now, which both conflict with stable Kdevelop:6 and kde-apps/kompare:6.

I cannot find in the code where it actually makes use of it.

On the contrary, I can find

> src/core/etcupdate.cpp: if (QStringLiteral("kdiff3") == KurooConfig::etcUpdateTool()) {

and in ChangeLog:

> Older Versions:
> 20-10-06
> Only kdiff3 is supported as merge tool.
(that's 2006, presumably)

but kdiff3 is not listed in RDEPEND.
Comment 1 Larry the Git Cow gentoo-dev 2024-09-10 18:07:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=230cd7c6f0ce6aa20b831f02c4438827ec124a81

commit 230cd7c6f0ce6aa20b831f02c4438827ec124a81
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-09-10 18:04:23 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-09-10 18:04:23 +0000

    app-portage/kuroo: Swap bogus kompare:5 RDEPEND for kde-misc/kdiff3
    
    Closes: https://bugs.gentoo.org/938928
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-portage/kuroo/kuroo-1.2.3-r1.ebuild | 48 +++++++++++++++++++++++++++++++++
 app-portage/kuroo/kuroo-9999.ebuild     |  4 +--
 2 files changed, 50 insertions(+), 2 deletions(-)
Comment 2 A Schenck 2024-11-12 00:44:01 UTC
Goodness, that changelog is very old. Anyways, there was an attempt to use kompare instead of kdiff3 on the assumption that the dependencies would be fewer, but maybe that branch got lost or something. And on further thought it seems like kdiff3 will be less troublesome in cases like this since it's outside of the main KDE bundle release system. It could also maybe be just an elog since the functionality to merge protected config files doesn't work unless kuroo is run as root. There will be a new version coming soon™ for the KF6 port which will probly replace the dependency with an elog.
Comment 3 Andreas Sturmlechner gentoo-dev 2024-11-12 16:55:26 UTC
(In reply to A Schenck from comment #2)
> It could also maybe be just an elog since the functionality to merge protected
> config files doesn't work unless kuroo is run as root.
In that case it should use kauth "to let applications perform actions as a privileged user" similar to, e.g., partitionmanager.