Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 938666 - app-xemacs/ebuild-mode-1.74 fails tests
Summary: app-xemacs/ebuild-mode-1.74 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: XEmacs team
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2024-08-29 06:35 UTC by Agostino Sarubbo
Modified: 2024-08-30 06:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,69.55 KB, text/plain)
2024-08-29 06:35 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-08-29 06:35:05 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-xemacs/ebuild-mode-1.74 fails tests.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2024-08-29 06:35:06 UTC
Created attachment 901521 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2024-08-29 17:46:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff54a7ac3f6552cd6dbc208583abb00070105efa

commit ff54a7ac3f6552cd6dbc208583abb00070105efa
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-08-29 17:45:17 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-08-29 17:46:07 +0000

    app-xemacs/ebuild-mode: add 1.75, drop 1.74
    
    Closes: https://bugs.gentoo.org/938666
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-xemacs/ebuild-mode/Manifest                                         | 2 +-
 .../ebuild-mode/{ebuild-mode-1.74.ebuild => ebuild-mode-1.75.ebuild}    | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
Comment 3 Larry the Git Cow gentoo-dev 2024-08-29 17:47:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=b5c893ab2e06457a0d2343e1b41e814d83dbf6dd

commit b5c893ab2e06457a0d2343e1b41e814d83dbf6dd
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-08-29 17:35:57 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-08-29 17:35:57 +0000

    Avoid date-to-time in tests
    
    * test/ebuild-mode-tests.el (ebuild-mode-test-run-with-fixed-time):
    * test/glep-mode-tests.el (glep-mode-test-run-with-fixed-time):
    Use encode-time instead of date-to-time. Bug 938666.
    
    Bug: https://bugs.gentoo.org/938666
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ChangeLog                 | 6 ++++++
 test/ebuild-mode-tests.el | 7 ++++++-
 test/glep-mode-tests.el   | 7 ++++++-
 3 files changed, 18 insertions(+), 2 deletions(-)
Comment 4 Ulrich Müller gentoo-dev 2024-08-30 06:38:02 UTC
More explanation, for future reference:

- date-to-time is not part of XEmacs but provided by app-xemacs/gnus. Adding a test dependency for one function would have been less than optimal (IMHO). Also there are subtle differences between implementations, e.g. XEmacs doesn't accept ISO 8601 time stamps like "2024-08-30T06:30:00Z".
- We cannot use Lisp time values because it changes all the time. The Emacs Lisp reference manual says: "Although traditionally Lisp timestamps were integer pairs, their form has evolved and programs ordinarily should not depend on the current default form." Also, as they measure seconds since the Epoch, they are not human readable.
- This leaves us with encode-time which used to accept SECOND, MINUTE, HOUR, DAY, MONTH, YEAR and ZONE as separate arguments (and still does in XEmacs). Unfortunately, its calling convention has changed in Emacs 27; it wants a list now. The old interface is still supported, but presumably it is only a matter of time before it goes away. See the commit in comment #3 for the (ugly) workaround using condition-case.