Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 938347 - dev-util/bpftool: unconditional dependency on sys-libs/binutils-libs can be relaxed
Summary: dev-util/bpftool: unconditional dependency on sys-libs/binutils-libs can be r...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Holger Hoffstätte
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-08-23 15:06 UTC by Holger Hoffstätte
Modified: 2024-08-24 11:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2024-08-23 15:06:15 UTC
The bpftool ebuild unconditionally depends on binutils-libs.
This is harmless but overly restrictive: binutils-libs is used when USE=-llvm for JIT disassembly. While this is the default and binutils-libs is a dependency of llvm anyway, there is no reason for a direct dependency esp. when USE=llvm is active.
Comment 1 Holger Hoffstätte 2024-08-23 15:37:49 UTC
Another sideshow problem is that the default -llvm pulls in llvm automagically.
Comment 2 Holger Hoffstätte 2024-08-23 15:47:17 UTC
(In reply to Holger Hoffstätte from comment #1)
> Another sideshow problem is that the default -llvm pulls in llvm
> automagically.

(sigh, I'm tired)

The default is +llvm so this works as advertised.
Nevertheless for the sake of simplicity it probably _should_ be off by default.
Comment 3 Larry the Git Cow gentoo-dev 2024-08-24 11:49:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0e4025c4005e56c41fa43c5c3db913174c46525

commit d0e4025c4005e56c41fa43c5c3db913174c46525
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2024-08-23 16:07:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-24 11:49:04 +0000

    dev-util/bpftool: relax binutils-libs dependency, do not USE=llvm by default
    
    Discussion on IRC found that the binutils-libs dependency can be
    relaxed and that default-enabling llvm is also not really necessary.
    This should help with the adoption of sys-devel/bpf-toolchain.
    
    Closes: https://bugs.gentoo.org/938347
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/38265
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/bpftool/bpftool-7.5.0-r1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)