Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 938241 - dev-vcs/git-filter-repo: arbitrarily depends on too-new versions of dev-vcs/git
Summary: dev-vcs/git-filter-repo: arbitrarily depends on too-new versions of dev-vcs/git
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mike Pagano
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-20 14:37 UTC by Eli Schwartz
Modified: 2024-08-20 22:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eli Schwartz gentoo-dev 2024-08-20 14:37:16 UTC
commit 538ebda96d47ee65043d1d9195f0fec1c4175712
Author:     Sam James <sam@gentoo.org>
AuthorDate: Wed Oct 12 19:27:00 2022
Commit:     Sam James <sam@gentoo.org>
CommitDate: Wed Oct 12 19:32:02 2022

    dev-vcs/git-filter-repo: misc tweaks
    
    - Depend on same git version as $(ver_cut 1-2) (we could arguably do 1-3, but..)
    - Use python_prepare_all
    - Tidy up PKG-INFO a tiny bit wrt indentation
    - Fix README.md installation
    
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-vcs/git-filter-repo/git-filter-repo-2.38.0-r1.ebuild | 35 +++++++++++++++++++++++------------
 1 file changed, 23 insertions(+), 12 deletions(-)



But filter-repo should not depend on the same git version as ver_cut anything at all. Because upstream filter-repo explicitly includes backwards compatibility with old versions of git, so you don't *have* to upgrade git in order to install filter-repo at all. If anything, it should have

RDEPEND="
    >=dev-vcs/git-2.22
    <=dev-vcs/git-$(ver_cut 1-2)*
"

Since it "cannot guarantee" compatibility with newer versions of git. But we don't usually pessimize like that...



Per https://github.com/newren/git-filter-repo#prerequisites

filter-repo requires:

    git >= 2.22.0 at a minimum; some features require git >= 2.24.0 or later
    python3 >= 3.6


The commit in question "broke everything", because before that it "correctly" depended on git >= 2.24.0, which is actually a bit much but still relatively quite neutral.

Currently, git-filter-repo has no stable keywords. I can try to accept ~amd64 for it but it was upgraded to 2.45.0 and old versions were dropped. git 2.45.0 is still ~arch so I would have to opt in to an unstable version of git just so I can install a niche tool at all.

This is not an ideal user experience.
Comment 1 Larry the Git Cow gentoo-dev 2024-08-20 22:25:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=94679559df78c78cab856cd4be980b8e3d04d5fd

commit 94679559df78c78cab856cd4be980b8e3d04d5fd
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2024-08-20 22:24:03 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2024-08-20 22:24:03 +0000

    dev-vcs/git-filter-repo: Rem git dep ver, make user exp more ideal
    
    Closes: https://bugs.gentoo.org/938241
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 dev-vcs/git-filter-repo/git-filter-repo-2.45.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)