Bug 938205 – www-client/firefox: add support for net-misc/connman when USE=wifi

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description José María Fernández González 2024-08-19 18:37:18 UTC]

www-client/firefox has the `wifi` USE flag, which enables necko-wifi for NetworkManager integration. Firefox (as its sibling project Thunderbird) talks to NetworkManager through its DBUS API.

net-misc/connman has `networkmanager` flag, which enables the compatibility implementation of the NetworkManager DBUS API, so clients using that API can talk to Connman as it were NetworkManager.

My request is adding a small change to the firefox ebuild like next, so Connman laptop users like me can enable `wifi` flag without having to maintain a local overlay to manage each release:

--- /var/db/repos/gentoo/www-client/firefox/firefox-129.0.1.ebuild      2024-08-16 15:41:14.000000000 +0200
+++ firefox-129.0.1.ebuild   2024-08-19 13:16:33.699936900 +0200
@@ -164,7 +164,10 @@
        )
        wifi? (
                kernel_linux? (
-                       net-misc/networkmanager
+                       || (
+                               net-misc/networkmanager
+                               net-misc/connman[networkmanager]
+                       )
                        sys-apps/dbus
                )
        )

I have been testing this small change in my local installation since more than one year, with no evident breakages.

Thanks in advance,
        José María

[Comment 1 Joonas Niilola 2024-08-20 04:52:25 UTC]

Yeah looks good. I'll implement it for the next round of version bumps, on 128+.

[Comment 2 Larry the Git Cow 2024-08-21 10:46:08 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7200cea618d6b3f1f8c3c59d98539ec29e565f82

commit 7200cea618d6b3f1f8c3c59d98539ec29e565f82
Author:     Joonas Niilola <[e-mail]>
AuthorDate: 2024-08-21 10:43:54 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2024-08-21 10:46:06 +0000

    www-client/firefox: add 129.0.2
    
     - allow net-misc/connman[networkmanager] to be used with +wifi use flag,
     - include a patch to fix pgo on musl when compiling for the first time,
     - remove tc-ld-is-mold function since it's merged into toolchain-funcs.eclass.
    
    Closes: https://bugs.gentoo.org/938205
    Bug: https://bugs.gentoo.org/929967
    Signed-off-by: Joonas Niilola <[e-mail]>

 www-client/firefox/Manifest               |  102 +++
 www-client/firefox/firefox-129.0.2.ebuild | 1370 +++++++++++++++++++++++++++++
 2 files changed, 1472 insertions(+)

[Comment 3 José María Fernández González 2024-08-27 19:20:42 UTC]

Thanks!!!

[Comment 4 Larry the Git Cow 2024-09-03 10:44:31 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d6c60914ebb21e53115ac5259e191e9dcd84279

commit 9d6c60914ebb21e53115ac5259e191e9dcd84279
Author:     Joonas Niilola <[e-mail]>
AuthorDate: 2024-09-03 10:42:54 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2024-09-03 10:44:28 +0000

    www-client/firefox: add 128.2.0
    
     - allow connman[networkmanager] to be used instead of networkmanager for +wifi,
     - drop many patches that have been merged upstream for esr128.2,
     - fix many seds,
     - install gnome-shell search-provider files,
     - remove tc-ld-is-mold function from the ebuild since it's now merged into
       toolchain-funcs.eclass,
     - sync changes between rapid and esr to ease up future maintenance.
    
    Closes: https://bugs.gentoo.org/938205
    Signed-off-by: Joonas Niilola <[e-mail]>

 www-client/firefox/Manifest               |  102 +++
 www-client/firefox/firefox-128.2.0.ebuild | 1354 +++++++++++++++++++++++++++++
 2 files changed, 1456 insertions(+)