Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937896 - dev-python/sentry-sdk: still requires <dev-python/pytest-8
Summary: dev-python/sentry-sdk: still requires <dev-python/pytest-8
Status: RESOLVED PKGREMOVED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexey Shvetsov
URL:
Whiteboard:
Keywords: PMASKED, PullRequest
Depends on: 941723
Blocks: pytest8
  Show dependency tree
 
Reported: 2024-08-14 06:02 UTC by Michał Górny
Modified: 2024-12-06 04:40 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-08-14 06:02:27 UTC
(CC-ing revdep maintainers)

I think we'll be lastriting it soon, since downgrading to <dev-python/pytest-8 is become more and more of a pain, and upstream seems not to care.  Their effort basically boils down to periodically trying pytest-8, and then deciding it still didn't magically start working with their old code.
Comment 1 Andreas Sturmlechner gentoo-dev 2024-08-14 10:14:41 UTC
Unfortunately the dependency is currently non-optional in kde-plasma/drkonqi. Losing that would mean dropping a major component from Plasma for instant on-crash guided bug reporting to bugs.kde.org.
Comment 2 Michael Mair-Keimberger (mm1ke) 2024-08-27 08:57:53 UTC
Hi,

for the gns3 packages sentry-sdk is also non-optional atm.
I'm not a big user of gns3 anymore but i'm still using it from time to time. However if this packages going to be removed, i guess gns3 will too.

I can make an upstream issue about this to let them know, maybe they can change the dependency somehow?
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-09-10 08:21:39 UTC
Ok, at this point I can't bump this package anymore.
Comment 4 Larry the Git Cow gentoo-dev 2024-10-07 17:23:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=dbd2b70822878e0272b3d9d8c282c0f605bf6ac9

commit dbd2b70822878e0272b3d9d8c282c0f605bf6ac9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-07 17:20:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-07 17:23:37 +0000

    kde-plasma/drkonqi: enable py3.13, drop sentry-sdk dep
    
    Per consultation with upstream, sentry-sdk is only used for reporting issues
    in the GDB Python script (gdb_preamble/preamble.py). This is pretty niche
    and not worth it given the issues mentioned in bug #937896.
    
    drkonqi does rely otherwise on sentry but it implements the protocol/format
    itself and not using the Python package.
    
    This unblocks py3.13 too.
    
    Bug: https://bugs.gentoo.org/937896
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-plasma/drkonqi/drkonqi-6.1.90.ebuild      | 3 +--
 kde-plasma/drkonqi/drkonqi-6.2.0.ebuild       | 3 +--
 kde-plasma/drkonqi/drkonqi-6.2.49.9999.ebuild | 3 +--
 kde-plasma/drkonqi/drkonqi-9999.ebuild        | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2024-10-07 17:24:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b334ffd4316e2846810968b0098fc192c34ef27

commit 7b334ffd4316e2846810968b0098fc192c34ef27
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-07 17:20:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-07 17:20:24 +0000

    kde-plasma/drkonqi: enable py3.13, drop sentry-sdk dep
    
    Per consultation with upstream, sentry-sdk is only used for reporting issues
    in the GDB Python script (gdb_preamble/preamble.py). This is pretty niche
    and not worth it given the issues mentioned in bug #937896.
    
    drkonqi does rely otherwise on sentry but it implements the protocol/format
    itself and not using the Python package.
    
    This unblocks py3.13 too.
    
    Bug: https://bugs.gentoo.org/937896
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-plasma/drkonqi/drkonqi-6.1.5-r1.ebuild | 90 ++++++++++++++++++++++++++++++
 1 file changed, 90 insertions(+)
Comment 6 Andreas Sturmlechner gentoo-dev 2024-10-07 18:02:56 UTC
Thanks, Sam.
Comment 7 Michael Mair-Keimberger (mm1ke) 2024-10-08 06:08:32 UTC
Just FYI: I've opened an upstream issue about sentry-sdk [1]. Lets see what they can say.

[1] https://github.com/GNS3/gns3-server/issues/2423
Comment 8 Larry the Git Cow gentoo-dev 2024-10-13 15:35:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e5f19e29b7e874b1593bcfed42dab8f2c33f9f0

commit 2e5f19e29b7e874b1593bcfed42dab8f2c33f9f0
Author:     Michael Mair-Keimberger <mmk@levelnine.at>
AuthorDate: 2024-10-13 07:47:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-10-13 15:31:28 +0000

    net-misc/gns3-gui: drop sentry-sdk dep
    
    Upstream is going to make sentry-sdk optional and it should be already
    possbile to run gns3 without it.
    
    Bug: https://github.com/GNS3/gns3-server/issues/2423
    Bug: https://bugs.gentoo.org/937896
    Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
    Closes: https://github.com/gentoo/gentoo/pull/38970
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../gns3-gui/{gns3-gui-2.2.48.1.ebuild => gns3-gui-2.2.48.1-r1.ebuild}   | 1 -
 net-misc/gns3-gui/{gns3-gui-2.2.49.ebuild => gns3-gui-2.2.49-r1.ebuild}  | 1 -
 2 files changed, 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d183bf2e4cd392629ebaedb5ff8b813fbfb6b6f9

commit d183bf2e4cd392629ebaedb5ff8b813fbfb6b6f9
Author:     Michael Mair-Keimberger <mmk@levelnine.at>
AuthorDate: 2024-10-13 07:46:36 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-10-13 15:31:22 +0000

    net-misc/gns3-server: drop sentry-sdk dep
    
    Upstream is going to make sentry-sdk optional and it should be already
    possbile to run gns3 without it.
    
    Bug: https://github.com/GNS3/gns3-server/issues/2423
    Bug: https://bugs.gentoo.org/937896
    Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../{gns3-server-2.2.48.1.ebuild => gns3-server-2.2.48.1-r1.ebuild}      | 1 -
 .../{gns3-server-2.2.49.ebuild => gns3-server-2.2.49-r1.ebuild}          | 1 -
 2 files changed, 2 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2024-10-18 14:42:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bc3e95719035bfc2b7516d01fe35c871e60a239c

commit bc3e95719035bfc2b7516d01fe35c871e60a239c
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-10-18 14:42:21 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-10-18 14:42:21 +0000

    package.mask: Last rite dev-python/sentry-sdk
    
    Bug: https://bugs.gentoo.org/937896
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 8 ++++++++
 1 file changed, 8 insertions(+)
Comment 10 Anthony Ryan 2024-10-28 16:17:50 UTC
We are now seeing some upstream activity on this problem!

They have unpinned pytest in git master for all versions of python >= 3.8

We already have PYTHON_COMPAT with a minimum of 3.11 in the ebuild, so I think our problem is solved on the next release.

Activity can be seen here: https://github.com/getsentry/sentry-python/issues/3035
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-10-28 16:26:16 UTC
Does that give a good chance of resolving 30+ random deselects we've had with pytest<8 anyway?
Comment 12 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 18:22:18 UTC
(In reply to Anthony Ryan from comment #10)
> We are now seeing some upstream activity on this problem!
> 
> They have unpinned pytest in git master for all versions of python >= 3.8

I see there's a new release out.  Do you feel like trying to prepare a PR updating the ebuild, and ideally see if you can remove some of the "TODO" deselects?
Comment 13 Anthony Ryan 2024-11-05 19:00:03 UTC
I'm open to preparing it. I've spent a few hours working on ebuild problems and got 50+ more tests run instead of skipped, and some additional ones green.

But after talking with the upstream developers: They have no intention of making the tests functional anywhere outside their company's private test environment. They consider the test suite for their internal use only, and everyone else is just a consumer of the package. Nobody else is expected to run tests.

Would the tree find it acceptable to disable tests permanently and drop all the test dependencies, with a comment explaining this?

If so, I'll prepare a pull request, but I don't believe there's any hope to save the test suite.
Comment 14 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-11-05 19:13:51 UTC
Yes, keeping this without tests at all is unacceptable.  Upstream testing is useless for Gentoo.  It doesn't guarantee that the package will work with the particular dependency versions that Gentoo users have installed, or on most of Gentoo architectures, or with new Python versions that upstreams don't test timely.
Comment 15 Anthony Ryan 2024-11-05 19:50:12 UTC
Understood. Then we'll need to feed it to the treecleaner.

If anyone has any suggestions for replacements that can be loaded into arbitrary python applications for centralized error collection/aggregation. I'd welcome suggestions.
Comment 16 Larry the Git Cow gentoo-dev 2024-12-06 04:40:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6a2bd6b0bc2cb622a5587da6fdd01f7e429624b

commit d6a2bd6b0bc2cb622a5587da6fdd01f7e429624b
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-12-06 04:35:15 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-12-06 04:36:47 +0000

    dev-python/sentry-sdk: Remove last-rited pkg
    
    Bug: https://bugs.gentoo.org/937896
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/sentry-sdk/Manifest                     |   2 -
 .../files/sentry-sdk-1.21.0-ignore-warnings.patch  |  12 --
 dev-python/sentry-sdk/metadata.xml                 |  17 ---
 dev-python/sentry-sdk/sentry-sdk-1.45.1.ebuild     | 155 ---------------------
 dev-python/sentry-sdk/sentry-sdk-2.13.0.ebuild     | 129 -----------------
 profiles/arch/arm/package.use.stable.mask          |   1 -
 profiles/features/wd40/package.use.mask            |   1 -
 profiles/package.deprecated                        |   7 -
 profiles/package.mask                              |   8 --
 9 files changed, 332 deletions(-)