Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937748 - games-puzzle/pingus has incorrect LICENSE
Summary: games-puzzle/pingus has incorrect LICENSE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-11 08:50 UTC by ganooslashlinus
Modified: 2024-08-11 11:46 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
scancode-toolkit output (pingus-0.7.6-r5.csv,423.76 KB, text/csv)
2024-08-11 08:50 UTC, ganooslashlinus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ganooslashlinus 2024-08-11 08:50:12 UTC
Created attachment 899829 [details]
scancode-toolkit output

LICENSE="GPL-3"

In the source I can't find any file that is GPLv3-only - files that have copyright headers say GPLv3-or-later.

scancode-toolkit agrees.

According to README in the development version, the license is GPLv3-or-later and there is no indication this is in relation to a license change; https://raw.githubusercontent.com/Pingus/pingus/master/README.md

Therefore, should be; LICENSE="GPL-3+"
Comment 1 ganooslashlinus 2024-08-11 09:01:50 UTC
I just noticed that external/tinygettext have GPLv2-or-later headers, same as a bunch of data files.

As those files aren't workable without the GPLv3+ parts and the package doesn't include a copy of the GPLv2, arguably those need to be upgraded to the GPLv3+ and so LICENSE="GPL-2+ GPL-3+" wouldn't be correct and LICENSE="GPL-3+" would be.
Comment 2 Larry the Git Cow gentoo-dev 2024-08-11 11:39:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2cceea3d9730a835aac7560357c8185f9745ece4

commit 2cceea3d9730a835aac7560357c8185f9745ece4
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-08-11 11:37:16 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-08-11 11:39:26 +0000

    games-puzzle/pingus: update LICENSE
    
    Closes: https://bugs.gentoo.org/937748
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 games-puzzle/pingus/pingus-0.7.6-r5.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Ulrich Müller gentoo-dev 2024-08-11 11:46:28 UTC
(In reply to ganooslashlinus from comment #1)
> I just noticed that external/tinygettext have GPLv2-or-later headers, same
> as a bunch of data files.

Also ZLIB for some files of the math library.

> As those files aren't workable without the GPLv3+ parts and the package
> doesn't include a copy of the GPLv2, arguably those need to be upgraded to
> the GPLv3+ and so LICENSE="GPL-2+ GPL-3+" wouldn't be correct and
> LICENSE="GPL-3+" would be.

LICENSE lists all licenses of the source files, not only the resulting license of the package. So for example, if some files are GPL-3+ and some are MIT, then we will list all of them, i.e. LICENSE="GPL-3+ MIT".

Policy reference:
htps://devmanual.gentoo.org/general-concepts/licenses/index.html
"The value of this variable should include all licenses pertaining to the 'corresponding source' of the files installed by the package. This includes all their source code, but also all scripts used to control compilation and installation. If the package has a 'main license' - i.e. a license covering most of its files - then this should be listed first."