Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937463 - sys-apps/gentoo-functions-1.7.1: installs files outside of EPREFIX
Summary: sys-apps/gentoo-functions-1.7.1: installs files outside of EPREFIX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://codeberg.org/kerframil/gentoo...
Whiteboard:
Keywords: PATCH
: 937768 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-08-06 19:51 UTC by Fabian Groffen
Modified: 2024-08-11 14:34 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2024-08-06 19:51:38 UTC
* QA Notice: the following files are outside of the prefix:
 * /lib
 * /lib/gentoo
 * /lib/gentoo/functions
 * /lib/gentoo/functions/rc.sh
 * /lib/gentoo/functions/portage.sh
 * /lib/gentoo/functions/experimental.sh
 * ERROR: sys-apps/gentoo-functions-1.7.1::gentoo failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
 * 
 * Call stack:
 *   misc-functions.sh, line 848:  Called install_qa_check
 *   misc-functions.sh, line 134:  Called source 'install_symlink_html_docs'
 *            05prefix, line 118:  Called install_qa_check_prefix
 *            05prefix, line  27:  Called die
 * The specific snippet of code:
 *                      die "Aborting due to QA concerns: there are files installed outside the prefix"


I'm not sure if it is the correct way but if I apply this sed the files are installed where it looks correct:

    sed -i -e 's:/lib/gentoo:lib/gentoo:' meson.build || die

Please advise what is the correct way to fix this.

Thanks
Comment 1 kfm 2024-08-07 01:34:50 UTC
I am by no means a meson expert but having it be a relative path does appear to be the appropriate fix, indeed. Thanks.
Comment 2 kfm 2024-08-07 01:48:41 UTC
Updating the URL. It rectifies a typo in the commit message that I thought I had already force-pushed.
Comment 3 Fabian Groffen gentoo-dev 2024-08-07 06:20:36 UTC
@maintainer: preference on how to push this fix? patch to ebuild?
Comment 4 Larry the Git Cow gentoo-dev 2024-08-07 06:23:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7afb263638d501ad69ed72d7982cb2878668e2cd

commit 7afb263638d501ad69ed72d7982cb2878668e2cd
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2024-08-07 06:21:47 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2024-08-07 06:22:54 +0000

    profiles/prefix/package.mask: mask gentoo-functions-1.7 and up
    
    These versions install files out of prefix, currently breaking the
    bootstrap process.
    
    Bug: https://bugs.gentoo.org/937463
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 profiles/prefix/package.mask | 4 ++++
 1 file changed, 4 insertions(+)
Comment 5 kfm 2024-08-10 21:08:39 UTC
(In reply to Fabian Groffen from comment #3)
> @maintainer: preference on how to push this fix? patch to ebuild?

Initially, I would have favoured a patch. However, given the time elapsed since you reported this and the subsequent advancements in the repo, it's probably going to end up being a new release. At present, my reviewer is a little backlogged but I wanted for you to know that it's in the pipeline. Your patience in this matter is appreciated.
Comment 6 Larry the Git Cow gentoo-dev 2024-08-11 10:11:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=51dfc37b304832e5c9099a6165529d06151ecabf

commit 51dfc37b304832e5c9099a6165529d06151ecabf
Author:     Kerin Millar <kfm@plushkava.net>
AuthorDate: 2024-08-07 00:21:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-11 10:10:52 +0000

    meson.build: avoid passing an absolute path to install_subdir()
    
    Otherwise, some of the files end up outside of EPREFIX.
    
    Fixes: 2a58c0e462538b7fb2d12cd95157a9aaf2b7f7ff
    Bug: https://bugs.gentoo.org/937463
    Reported-by: Fabian Groffen <grobian@gentoo.org>
    Signed-off-by: Kerin Millar <kfm@plushkava.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Larry the Git Cow gentoo-dev 2024-08-11 10:26:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eaf30a2314bac219042e9ec5b283c865cc67b25f

commit eaf30a2314bac219042e9ec5b283c865cc67b25f
Author:     Kerin Millar <kfm@plushkava.net>
AuthorDate: 2024-08-11 02:52:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-11 10:25:49 +0000

    sys-apps/gentoo-functions: add 1.7.2
    
    Also, sync the version 9999 ebuild.
    
    Closes: https://bugs.gentoo.org/937463
    Signed-off-by: Kerin Millar <kfm@plushkava.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/gentoo-functions/Manifest                 |  1 +
 .../gentoo-functions/gentoo-functions-1.7.2.ebuild | 49 ++++++++++++++++++++++
 .../gentoo-functions/gentoo-functions-9999.ebuild  |  7 +---
 3 files changed, 52 insertions(+), 5 deletions(-)
Comment 8 Larry the Git Cow gentoo-dev 2024-08-11 10:28:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5a7da78be1336c3dfd67a0006ee6366c1d23c8f

commit b5a7da78be1336c3dfd67a0006ee6366c1d23c8f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-08-11 10:27:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-11 10:27:51 +0000

    profiles/prefix: drop obsolete gentoo-functions mask for prefix
    
    Bug: https://bugs.gentoo.org/937463
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/prefix/package.mask | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Comment 9 Mike Gilbert gentoo-dev 2024-08-11 14:34:36 UTC
*** Bug 937768 has been marked as a duplicate of this bug. ***