Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937458 - sys-fs/btrfs-progs should have some way to set --enable-experimental
Summary: sys-fs/btrfs-progs should have some way to set --enable-experimental
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-06 16:53 UTC by Mark Harmstone
Modified: 2024-08-08 10:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Harmstone 2024-08-06 16:53:53 UTC
It would be useful if btrfs-progs had a USE flag to set the --enable-experimental configure flag, as some of the tests in https://github.com/kdave/xfstests rely on this.
Comment 1 Mark Harmstone 2024-08-06 16:54:34 UTC
See https://github.com/gentoo/gentoo/pull/37918
Comment 2 Paul Zander 2024-08-06 16:59:42 UTC
You can set EXTRA_ECONF="--enable-experimental" already.
Comment 3 Mark Harmstone 2024-08-06 17:03:34 UTC
(In reply to Paul Zander from comment #2)
> You can set EXTRA_ECONF="--enable-experimental" already.

Thanks, but I think this really ought to be a USE flag. There's also the issue that it doesn't install btrfs-corrupt-block by default, which xfstests also needs. My patch fixes both of these.
Comment 4 Larry the Git Cow gentoo-dev 2024-08-08 10:56:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a429b970949c21e97dfc4e6b8cee01ed0bb4e2ff

commit a429b970949c21e97dfc4e6b8cee01ed0bb4e2ff
Author:     Mark Harmstone <mark@harmstone.com>
AuthorDate: 2024-08-01 15:55:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-08 10:56:34 +0000

    sys-fs/btrfs-progs: add experimental USE flag
    
    Add experimental USE flag to btrfs-progs, which sets the
    --enable-experimental configure option and installs btrfs-corrupt-block,
    which is otherwise ignored. Both of these changes are required for
    xfstests to function correctly.
    
    Closes: https://bugs.gentoo.org/937458
    Signed-off-by: Mark Harmstone <mark@harmstone.com>
    Closes: https://github.com/gentoo/gentoo/pull/37918
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-fs/btrfs-progs/btrfs-progs-6.9.2.ebuild | 9 +++++++--
 sys-fs/btrfs-progs/metadata.xml             | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)