Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937407 - dev-util/perf: fails to apply kernel update patches
Summary: dev-util/perf: fails to apply kernel update patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Guilherme Amadio
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-05 20:33 UTC by Holger Hoffstätte
Modified: 2024-08-06 10:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2024-08-05 20:33:32 UTC
While fixing #937402 I discovered that perf does not actually apply any incremental patches on top of the base kernel tree. This is because the list of directories passed to filterdiff does not contain correct expressions (directories need a trailing /*) and therefore the applied patch file is empty.
Also filterdiff does not handle xz-compressed input, so it fails successfully with exit code 0 even before not filtering patches.


Reproducible: Always

Steps to Reproduce:
1. bump perf to e.g. 6.10.3
2. inspect patch in $WORKDIR
3. it's empty
Actual Results:  
No patch applied

Expected Results:  
Patch applied
Comment 1 Larry the Git Cow gentoo-dev 2024-08-06 10:16:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=691f5d53899938ee921c032ee027e90c1f4a28e6

commit 691f5d53899938ee921c032ee027e90c1f4a28e6
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2024-08-05 19:01:57 +0000
Commit:     Guilherme Amadio <amadio@gentoo.org>
CommitDate: 2024-08-06 10:15:44 +0000

    dev-util/perf: bump to 6.10.3 & correctly apply patch updates
    
    Closes: https://bugs.gentoo.org/937407
    Closes: https://github.com/gentoo/gentoo/pull/37984
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Signed-off-by: Guilherme Amadio <amadio@gentoo.org>

 dev-util/perf/Manifest           |   1 +
 dev-util/perf/perf-6.10.3.ebuild | 344 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 345 insertions(+)