Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937282 - media-sound/audacity-3.7.0: please bump
Summary: media-sound/audacity-3.7.0: please bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-04 11:34 UTC by Miroslav Šulc
Modified: 2024-10-31 19:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Šulc gentoo-dev 2024-08-04 11:34:43 UTC
https://github.com/audacity/audacity/releases
Comment 2 Mark 2024-09-04 15:22:00 UTC
I tried to create an ebuild from the 9999 version by first removing all applied patches, because neither the current git-sources nor version 3.6.2 compile with them (the patches cannot be applied).

I found out there seems to be a new dependency since Nov '23 to media-libs/allegro from libraries/lib-note-track that came in with audacity 3.5 but the audacity docs and relnotes don't mention the build dependency at all and the commits of the libs (https://github.com/audacity/audacity/commits/master/libraries/lib-note-track) also don't mention details on the used version or why they even need it (the lib is about some old MIDI stuff that is probably completely unimportant).

After adding the dependency to the ebuild compilation fails with allegro v4 due to a couple of C++ errors (a gigaton of incomplete types and followups).

Compilation with allegro v5 fails too: First, the audacity source has to be fixed to include the allegro.h header properly (from "allegro.h" to <allegro5/allegro.h>) but then it still fails with types not in scope and undeclared names.

Trying to delete this lib-note-track from audacity (from libraries/CMakeLists.txt) also breaks compilation as other stuff depends on it.

I gave up on that steaming pile of errors.
Too bad that audacity 3.4 is quite broken on Wayland due to interface issues.
Comment 6 Miroslav Šulc gentoo-dev 2024-10-31 18:34:34 UTC
i seem to have a working version, just going through the patches...
Comment 7 Larry the Git Cow gentoo-dev 2024-10-31 19:05:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a64113fee10ee2a0131aae6f2eb241f0f754b64

commit 7a64113fee10ee2a0131aae6f2eb241f0f754b64
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2024-10-31 19:05:11 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-10-31 19:05:21 +0000

    media-sound/audacity: bump to 3.7.0 + scrubbed patches
    
    Closes: https://bugs.gentoo.org/937282
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/audacity/Manifest                      |   1 +
 media-sound/audacity/audacity-3.7.0.ebuild         | 227 +++++++++++++++++++++
 ...audacity-3.2.3-allow-overriding-alsa-jack.patch |   9 -
 .../files/audacity-3.2.3-disable-ccache.patch      |   8 -
 .../audacity/files/audacity-3.3.3-Findlibmad.patch |   8 -
 .../files/audacity-3.3.3-fix-includes.patch        |   9 -
 .../audacity/files/audacity-3.3.3-fix-rpaths.patch |  20 +-
 ...audacity-3.3.3-local-threadpool-libraries.patch |  10 +-
 ...dacity-3.3.3-remove-conan-test-dependency.patch |   6 -
 .../audacity-3.3.3-upstream-fix-rapidjson.patch    |  12 --
 .../files/audacity-3.4.2-audiocom-std-string.patch |   6 -
 ...audacity-3.4.2-fix-build-with-use-lv2-off.patch |   6 -
 ...audacity-3.7.0-allow-overriding-alsa-jack.patch |  39 ++++
 .../files/audacity-3.7.0-audiocom-std-string.patch |  24 +++
 .../files/audacity-3.7.0-disable-ccache.patch      |  22 ++
 ...audacity-3.7.0-local-threadpool-libraries.patch |  30 +++
 .../audacity/files/audacity-3.7.0-portsmf.patch    |  11 +
 17 files changed, 366 insertions(+), 82 deletions(-)
Comment 8 Miroslav Šulc gentoo-dev 2024-10-31 19:06:29 UTC
there is still an issue in configuration when tests are enabled, but i'm already tired to have a look at it. if anybody is willing to fix it, here's the output:

-- Configuring done (3.9s)
CMake Error at cmake-proxies/cmake-modules/AudacityTesting.cmake:67 (target_link_libraries):
  Target "lib-time-and-pitch-test" links to:

    mpg123::libmpg123

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  libraries/lib-time-and-pitch/tests/CMakeLists.txt:7 (add_unit_test)


CMake Error at cmake-proxies/cmake-modules/AudacityTesting.cmake:67 (target_link_libraries):
  Target "lib-stretching-sequence-test" links to:

    mpg123::libmpg123

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  libraries/lib-stretching-sequence/tests/CMakeLists.txt:7 (add_unit_test)


CMake Error at cmake-proxies/cmake-modules/AudacityTesting.cmake:67 (target_link_libraries):
  Target "lib-music-information-retrieval-test" links to:

    mpg123::libmpg123

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  libraries/lib-music-information-retrieval/tests/CMakeLists.txt:9 (add_unit_test)