Upstream has released Audacious version 4.4 as of Jun 12 2024. Gentoo still has audacious 4.3.1 dated Apr 29 2023. Reproducible: Always Potential ebuilds attached, audacious and audacious-plugins need to be bumped together. Upstream now prefers meson, however my ebuilds still use autotools - but it works.
Created attachment 898484 [details] audacious ebuild
Created attachment 898485 [details] audacious-plugins
dependencies are now also qt6 opposed qt5
Wrong $LICENSE on audacious-plugins - src/skins/main.h has had a GPL-3 header since 2008 and this ebuild does not expose the option to build without it.
(In reply to m from comment #0) > Upstream has released Audacious version 4.4 as of Jun 12 2024. > Gentoo still has audacious 4.3.1 dated Apr 29 2023. (The dates really don't matter much if it was only released last month.) > > Upstream now prefers meson, however my ebuilds still use autotools - but it > works. As for the ebuild itself, please try switch to meson, as I mentioned before on IRC. I think there's also a missing dep on dev-qt/qtsvg? (See https://github.com/audacious-media-player/audacious/blob/master/acinclude.m4#L243 and https://wiki.gentoo.org/wiki/Project:Qt/Qt6_migration_notes). Please also include patches in the form of `git format-patch` output attached here or github PRs.
(In reply to m from comment #2) > Created attachment 898485 [details] > audacious-plugins There's deps on qt5 here. Is that right?
Created attachment 898593 [details] upgraded to meson, added qt5, qt6 use flags
Created attachment 898594 [details] upgraded to meson, added missing dep, added qt5, qt6 support.
Created attachment 898596 [details] audacious ebuild - corrected so qt5 and qt6 cant be enabled at the same time
Created attachment 898597 [details] audacious-plugins ebuild - correct so that qt5 and qt6 cannot be enabled at same time
Created attachment 898600 [details] audacious ebuild fixed formatting / logic
Created attachment 898601 [details] audacious-plugins fixed formatting / logic
(In reply to m from comment #12) > Created attachment 898601 [details] > audacious-plugins > > fixed formatting / logic > elif use qt5; then > emesonargs+=( > -Dqt=false > -Dqt5=true > ) > fi This won't work. -Dqt=false causes -Dqt5 to be skipped and disables the UI entirely.
Created attachment 898604 [details] audacious ebuild gtk support added and wired up, fixed issue with qt5
Created attachment 898605 [details] audacious-plugins ebuild gtk support added and wired up, qt5 issue fixed
Created attachment 898606 [details] audacious ebuild -added checks to make sure toolkit use flags on audacious and audacious-plugins dont become out of sync. - cleaned up ebuild
Created attachment 898607 [details] audacious-plugins ebuild - Added checks to make sure toolkit use flags dont become out of sync with audacious
Created attachment 898608 [details] audacious ebuild clean ups
Created attachment 898609 [details] audacious-plugins ebuild clean ups
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5b060cbb51fb5ccad2f16c55e35da5b75aa709e commit f5b060cbb51fb5ccad2f16c55e35da5b75aa709e Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2024-09-25 01:50:20 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2024-10-01 21:00:39 +0000 media-plugins/audacious-plugins: Version bump to 4.4.1 Closes: https://bugs.gentoo.org/936859 Signed-off-by: Matt Turner <mattst88@gentoo.org> media-plugins/audacious-plugins/Manifest | 1 + .../audacious-plugins-4.4.1.ebuild | 204 +++++++++++++++++++++ 2 files changed, 205 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=362519f49d304ec012f297e717b92a76bbb3dab4 commit 362519f49d304ec012f297e717b92a76bbb3dab4 Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2024-09-25 01:39:36 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2024-10-01 21:00:38 +0000 media-sound/audacious: Version bump to 4.4.1 Closes: https://bugs.gentoo.org/936859 Signed-off-by: Matt Turner <mattst88@gentoo.org> media-sound/audacious/Manifest | 1 + media-sound/audacious/audacious-4.4.1.ebuild | 67 ++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+)
