Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 936789 - media-libs/noise-suppression-for-voice should install the pipewire config
Summary: media-libs/noise-suppression-for-voice should install the pipewire config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-07-27 16:02 UTC by martin-kokos
Modified: 2024-07-28 02:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description martin-kokos 2024-07-27 16:02:50 UTC
I think the ebuild should install the config required for pipewire to know about this module as given example here https://github.com/werman/noise-suppression-for-voice#pipewire
With the appropriate library path filled in.
For Pulseaudio too I guess.

Reproducible: Always

Steps to Reproduce:
1. emerge media-libs/noise-suppression-for-voice
2. only the .so is installed

Actual Results:  
package is not useful until one figures out to go to repo Readme and add a config file for pipewire

Expected Results:  
A noise canceling source should be provided in order for this package to be useful for main usecase of denoising microphone input for teleconferencing.

Or at least ewarn on what to do.

example pipewire config in readme
https://github.com/werman/noise-suppression-for-voice#pipewire
Comment 1 Kacper Słomiński 2024-07-27 20:01:21 UTC
IMO letting the user set up the per-user config themselves is better than installing a system-wide one, since it has values the user might want to tweak (thresholds, etc). I agree that we should tell the user where to find info about how to configure it though.
Comment 2 Larry the Git Cow gentoo-dev 2024-07-28 02:39:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd27adc3beb65cda8f4226a1e9300d80300010ba

commit cd27adc3beb65cda8f4226a1e9300d80300010ba
Author:     Kacper Słomiński <kacper.slominski72@gmail.com>
AuthorDate: 2024-07-28 00:06:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-28 02:35:51 +0000

    media-libs/noise-suppression-for-voice: add 1.10-r1, update live
    
    The new revision installs a sample PipeWire configuration file.
    Additionally, we're getting rid of the "ladspa" USE flag, to make sure
    the configuration always works. This shouldn't be a problem as the
    ladspa plugin is not that heavy compared to all the other ones. This
    also lets us clean up REQUIRED_USE.
    
    Closes: https://bugs.gentoo.org/936789
    Signed-off-by: Kacper Słomiński <kacper.slominski72@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/99-input-denoising.conf                  | 33 +++++++++
 .../noise-suppression-for-voice-1.10-r1.ebuild     | 82 ++++++++++++++++++++++
 .../noise-suppression-for-voice-9999.ebuild        | 23 +++++-
 3 files changed, 135 insertions(+), 3 deletions(-)