Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 936507 - media-gfx/digikam[heif] broken with MULTILIB_WRAPPED_HEADERS
Summary: media-gfx/digikam[heif] broken with MULTILIB_WRAPPED_HEADERS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andreas K. Hüttel
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:
Keywords: UPSTREAM
: 936663 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-07-23 00:43 UTC by Michael Cook
Modified: 2024-07-26 09:15 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Cook 2024-07-23 00:43:40 UTC 
digikam uses regex on the header file to figure out the version

https://invent.kde.org/graphics/digikam/-/blob/128d9c9fc73015309128f0863d7768e9e5fd3e0c/core/cmake/modules/FindLibheif.cmake#L56

This breaks with libheif using MULTILIB_WRAPPED_HEADERS

Snippet:

 CMake Error at core/cmake/modules/FindLibheif.cmake:57 (string):
  string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  core/CMakeLists.txt:56 (find_package)


Reproducible: Always
Comment 1 Greg Kubaryk 2024-07-23 01:41:50 UTC 
All bugs need emerge --info as a comment and build.log as an attachment.
Comment 2 Michael Cook 2024-07-23 02:26:09 UTC 
(In reply to Greg Kubaryk from comment #1)
> All bugs need emerge --info as a comment and build.log as an attachment.

There is enough info provided. media-libs/libheif-1.17.6 (and I assume live ebuild) are the only ones it happens with since they use MULTILIB_WRAPPED_HEADERS where 1.15.2-r1 doesn't.


-- Found Libheif: /usr/include
-- HEIF_FOUND        = TRUE
-- HEIF_INCLUDE_DIRS = /usr/include
-- HEIF_LIBRARIES    = /usr/lib64/libheif.so
-- HEIF_DEFINITIONS  =
-- HEIF_VERSION      =


is probably useful too.
Comment 3 SigHunter 2024-07-23 08:53:53 UTC 
Upstream bug https://bugs.kde.org/show_bug.cgi?id=490690
Comment 4 Michael Cook 2024-07-23 14:01:53 UTC 
(In reply to SigHunter from comment #3)
> Upstream bug https://bugs.kde.org/show_bug.cgi?id=490690

This does appear to allow it to compile at least and the project doesn't appear to make use of the HEIF_VERSION variable, but the variable is still not being correctly parsed. I'm not sure how standard it is for cmake files to use regex on a header file to get version info, but I'm sure there is probably other examples. Now the question is, are there any other packages broken by this and MULTILIB_WRAPPED_HEADERS being used ...
Comment 5 Larry the Git Cow gentoo-dev 2024-07-23 16:11:09 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85ded2c23ee2ff9282564dd602e5157c9b7e25fc

commit 85ded2c23ee2ff9282564dd602e5157c9b7e25fc
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-07-23 15:30:44 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-07-23 16:11:02 +0000

    media-gfx/digikam: Fix build w/ media-libs/libheif-1.17.6
    
    Closes: https://bugs.gentoo.org/936507
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/digikam/digikam-8.4.0.ebuild             |  1 +
 .../digikam-8.4.0-fix-find_libheif-regex.patch     | 25 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-26 09:15:04 UTC 
*** Bug 936663 has been marked as a duplicate of this bug. ***