Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935897 - www-apps/radicale: missing description in service file (/etc/init.d/radicale)
Summary: www-apps/radicale: missing description in service file (/etc/init.d/radicale)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial
Assignee: Henning Schild
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-07-12 11:02 UTC by Stefan Römer
Modified: 2024-08-13 12:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Römer 2024-07-12 11:02:33 UTC
Just a trivial thing, but due to a missing description in the service file /etc/init.d/radicale (I use Gentoo with openrc) following messages appear in the syslog:

Jul 12 17:18:10 vs /etc/init.d/radicale[22943]: No description for radicale
Jul 12 17:18:10 vs /etc/init.d/radicale[22944]: healthcheck: no description
Jul 12 17:18:10 vs /etc/init.d/radicale[22945]: unhealthy: no description

I think a description doesn't hurt and therefore recommend adding the following one to keep the syslog a bit cleaner:

description="Radicale is a small but powerful CalDAV and CardDAV server"

Reproducible: Always

Steps to Reproduce:
1. Install Radicale
2. Start it
3. Have a look in the syslog
Actual Results:  
Radicale is declared 'unhealthy' in the syslog, even if it seems to work fine.

Expected Results:  
Just a bit cleaner syslog.

The file to add the description too should be www-apps/radicale/files/radicale-r3.init.d in the repo.
Comment 1 Henning Schild 2024-08-05 15:15:34 UTC
https://github.com/gentoo/gentoo/pull/37980
Comment 2 Henning Schild 2024-08-06 08:17:04 UTC
Not sure why "/etc/init.d/radicale describe" output end up in syslog in the first place. The PR on github will also not address "healthcheck" and "unhealthy" not having a description, these are functions not implemented by the service and not having default descriptions.
Comment 3 Larry the Git Cow gentoo-dev 2024-08-13 12:41:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bbf423c1a494c9e17e1f7dafaf52164c3f0205e2

commit bbf423c1a494c9e17e1f7dafaf52164c3f0205e2
Author:     Henning Schild <henning@hennsch.de>
AuthorDate: 2024-08-05 15:06:14 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-08-13 12:34:26 +0000

    www-apps/radicale: add openrc service description
    
    Closes: https://bugs.gentoo.org/935897
    Signed-off-by: Henning Schild <henning@hennsch.de>
    Closes: https://github.com/gentoo/gentoo/pull/37980
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-apps/radicale/files/radicale-r4.init.d | 28 ++++++++++
 www-apps/radicale/radicale-3.1.9-r1.ebuild | 90 ++++++++++++++++++++++++++++++
 2 files changed, 118 insertions(+)