Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935841 - gnome-extra/gnome-network-displays: libportal dependency also missing [gtk] use flag as dependency
Summary: gnome-extra/gnome-network-displays: libportal dependency also missing [gtk] u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-10 21:58 UTC by Vladimir C. Popa
Modified: 2024-07-12 08:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir C. Popa 2024-07-10 21:58:11 UTC
Apologies if this is wrongly posted, first time here, I thought I can help with this minor thing.

Having gnome-extra/gnome-network-displays already installed as 0.90.5-r1 trying to update to 0.92.1 caused the build to fail, with the meson precheck complaining that:

----
Run-time dependency libportal-gtk4 found: NO (tried pkgconfig and cmake)

src/meson.build:46:2: ERROR: Dependency "libportal-gtk4" not found, tried pkgconfig and cmake
----

I realized that having installed gui-libs/gtk-4.14.4 and dev-libs/libportal-0.7.1 was not enough as I did not had the "gtk" use flag enabled for libportal. Adding it to packages.use reemerging it and then reemerging gnome-network-displays worked.

Checking the gnome-network-displays-0.92.1.ebuild file I saw it has (many lines ommited as not relevant):
>=gui-libs/gtk-4
>=dev-libs/libportal-0.7

and I think it should be:
>=gui-libs/gtk-4
>=dev-libs/libportal-0.7[gtk]

Though I haven't tested that and creating a pull request seemed daunting and it's almost 1 AM. When I'll have some time, if it's still needed I'll do a test and make the pull request too.
Comment 1 Larry the Git Cow gentoo-dev 2024-07-12 08:50:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b0012a99065cb94460f9d2d655ac262b6fc0bb4

commit 5b0012a99065cb94460f9d2d655ac262b6fc0bb4
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2024-07-12 08:49:42 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2024-07-12 08:50:22 +0000

    gnome-extra/gnome-network-displays: Fix dependencies
    
    Thanks-to: Vladimir C. Popa
    Closes: https://bugs.gentoo.org/935841
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 gnome-extra/gnome-network-displays/gnome-network-displays-0.92.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)