Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935685 - Portage does not adhere to make.defaults quoting requirement
Summary: Portage does not adhere to make.defaults quoting requirement
Status: UNCONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Configuration (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 563798
  Show dependency tree
 
Reported: 2024-07-07 00:32 UTC by Jannik Glückert
Modified: 2024-07-07 11:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jannik Glückert 2024-07-07 00:32:46 UTC
make.defaults syntax is defined in PMS 5.2.4:
> The file itself is a line-based key-value format. Each line contains a single VAR="value" entry, where the value must be double quoted.

Yet, it seems that portage accepts unquoted VAR=value syntax in profiles, as has been present for a while now e.g. in https://github.com/gentoo/gentoo/blob/595c607772111487ab160081434422a98118e566/profiles/features/llvm/make.defaults#L34

tested with portage 3.0.64-r3
Comment 1 Larry the Git Cow gentoo-dev 2024-07-07 02:08:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=916cafa15adec6ebe8898b424ca345c8bb907161

commit 916cafa15adec6ebe8898b424ca345c8bb907161
Author:     Jannik Glückert <jannik.glueckert@gmail.com>
AuthorDate: 2024-07-07 01:35:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-07 02:07:59 +0000

    profiles: fix make.defaults quoting
    
    quoting is required as per PMS 5.2.4
    
    Bug: https://bugs.gentoo.org/935685
    Signed-off-by: Jannik Glückert <jannik.glueckert@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/37464
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/features/hardened/make.defaults  | 2 +-
 profiles/features/llvm/make.defaults      | 2 +-
 profiles/features/split-usr/make.defaults | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2024-07-07 11:07:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7e79e60d0c9c96f2b171dc563991d74fdeb444b

commit a7e79e60d0c9c96f2b171dc563991d74fdeb444b
Author:     Jannik Glückert <jannik.glueckert@gmail.com>
AuthorDate: 2024-07-07 09:47:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-07 11:07:19 +0000

    profiles: fix make.defaults quoting, part 2
    
    quoting is required as per PMS 5.2.4
    amends 916cafa15adec6ebe8898b424ca345c8bb907161
    
    Bug: https://bugs.gentoo.org/935685
    Signed-off-by: Jannik Glückert <jannik.glueckert@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/37472
    Signed-off-by: Sam James <sam@gentoo.org>

 .../features/prefix/standalone/kernel-2.6.16+/make.defaults    | 10 +++++-----
 .../features/prefix/standalone/kernel-2.6.32+/make.defaults    |  2 +-
 profiles/features/prefix/standalone/make.defaults              |  2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)