Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935510 - app-office/onlyoffice-bin: pulls unnecessary deps
Summary: app-office/onlyoffice-bin: pulls unnecessary deps
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Alfred Wingate
URL: https://github.com/gentoo/gentoo/blob...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-07-05 00:07 UTC by Justin
Modified: 2024-07-05 17:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin 2024-07-05 00:07:06 UTC
I'm unsure if this is intentional so please correct me if I'm wrong. I'm also unsure if this is the right place to post, if you would prefer I open a pull request instead please let me know.

onlyoffice-bin pulls the wayland dependencies below on an x11 system, even though they are unneeded. I've masked them on my system and the program launches without any errors. It may make more sense to hide them under a use flag, let me know your thoughts.

dev-qt/qtwayland
dev-libs/wayland
dev-util/wayland-scanner


Reproducible: Always

Steps to Reproduce:
1. emerge app-office/onlyoffice-bin
Actual Results:  
Pulls wayland deps

Expected Results:  
Wayland should not be pulled if not in use
Comment 1 Alfred Wingate 2024-07-05 00:40:41 UTC
Already had a PR pending that went through the dependencies, in that I removed the dev-libs/wayland dependency as it wasn't required as far as I knew.
Comment 2 Larry the Git Cow gentoo-dev 2024-07-05 17:08:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5c49397c9a14102389f766256d8a8b29bd5cb48

commit f5c49397c9a14102389f766256d8a8b29bd5cb48
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2024-06-20 15:30:47 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2024-07-05 17:03:35 +0000

    app-office/onlyoffice-bin: add 8.1.0
    
    Closes: https://bugs.gentoo.org/935510
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 app-office/onlyoffice-bin/Manifest                 |  1 +
 .../onlyoffice-bin/onlyoffice-bin-8.1.0.ebuild     | 85 ++++++++++++++++++++++
 2 files changed, 86 insertions(+)