Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935491 - media-libs/libgphoto2-2.5.31-r1 accesses the USE variable directly
Summary: media-libs/libgphoto2-2.5.31-r1 accesses the USE variable directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 940075
  Show dependency tree
 
Reported: 2024-07-04 16:50 UTC by Ulrich Müller
Modified: 2024-09-22 18:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2024-07-04 16:50:44 UTC
pkg_pretend() {
	if ! echo "${USE}" | grep "cameras_" > /dev/null 2>&1; then
		einfo "No camera drivers will be built since you did not specify any."
	fi
}

The ebuild should not access the USE variable directly. It should check the CAMERAS use-expand instead.

Alternatively (and maybe preferably), it could calculate REQUIRED_USE="|| ( ... )" from IUSE_CAMERAS.
Comment 1 Larry the Git Cow gentoo-dev 2024-07-09 18:39:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bbad92ec847597037513ade0f8168bc8ae391cd7

commit bbad92ec847597037513ade0f8168bc8ae391cd7
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-07-06 10:08:27 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2024-07-09 18:38:44 +0000

    media-libs/libgphoto2: Fix USE and IUSE handling
    
    Closes: https://bugs.gentoo.org/935491
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/37456
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 media-libs/libgphoto2/libgphoto2-2.5.31-r2.ebuild | 216 ++++++++++++++++++++++
 1 file changed, 216 insertions(+)