Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935410 - dev-libs/nettle-3.9.1-r1 in-ebuild altivec check always fails
Summary: dev-libs/nettle-3.9.1-r1 in-ebuild altivec check always fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-07-03 15:11 UTC by Nick Bowler
Modified: 2024-07-04 01:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (nettle.patch,540 bytes, patch)
2024-07-03 15:13 UTC, Nick Bowler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Bowler 2024-07-03 15:11:26 UTC
Hi,

The dev-lang/nettle-3.9.1-r1 ebuild contains this code:

  # https://git.lysator.liu.se/nettle/nettle/-/issues/7
  if use cpu_flags_ppc_altivec && ! tc-cpp-is-true "defined(__VSX__) && __VSX__ == 1" "${CPPFLAGS}" "${CFLAGS}" ; then
    ewarn "cpu_flags_ppc_altivec is enabled, but nettle's asm requires >=P7."
    ewarn "Disabling, sorry! See bug #920234."
    myeconfargs+=( --disable-power-altivec )
  fi

This unconditionally disables altivec because the invocation of tc-cpp-is-true
is incorrect.  tc-cpp-is-true quotes the arguments to the compiler so by
passing a quoted CPPFLAGS and CFLAGS, the compiler gets exactly two
quoted arguments instead of having them split by the shell as expected.

In my case, the compiler invocation in tc-cpp-is-true looks like this:

  powerpc64le-unknown-linux-gnu-gcc -E '' '-O2 -pipe -mcpu=power9 -mtune=power9' -P -

which is an invalid compiler command so the test always fails.  Just removing
the unwanted quotes from the ebuild is sufficient to avoid this problem.

Portage 3.0.63 (python 3.12.4-final-0, default/linux/ppc64le/17.0, gcc-13, glibc-2.39-r6, 6.9.5 ppc64le)
=================================================================
System uname: Linux-6.9.5-ppc64le-POWER9,_altivec_supported-with-glibc2.39
KiB Mem:    66547840 total,  39676672 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Wed, 03 Jul 2024 00:45:00 +0000
Head commit of repository gentoo: fb0e9e0278ffac78d76f3db04ed24aaebef5252c
sh dash 0.5.12
ld GNU ld (Gentoo 2.41 p5) 2.41.0
ccache version 4.9.1 [enabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p26-r6::gentoo
dev-build/autoconf:        2.13-r8::gentoo, 2.71-r7::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.28.5::gentoo
dev-build/libtool:         2.4.7-r4::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.4.0-r1::gentoo
dev-lang/perl:             5.38.2-r3::gentoo
dev-lang/python:           3.11.9-r1::gentoo, 3.12.4_p1::gentoo
dev-lang/rust:             1.77.1::gentoo
dev-util/ccache:           4.9.1-r1::gentoo
sys-apps/baselayout:       2.15::gentoo
sys-apps/openrc:           0.54::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/binutils:        2.41-r5::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo
sys-devel/gcc:             13.2.1_p20240210::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/llvm:            17.0.6::gentoo
sys-kernel/linux-headers:  6.6-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.39-r6::gentoo
Repositories:

gentoo
    location: /srv/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://athena.draconx.ca/gentoo-portage
    priority: -1000
    volatile: True
    sync-rsync-verify-metamanifest: no
    sync-rsync-verify-max-age: 3
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 

gentoo-draconx
    location: /srv/repos/gentoo-draconx
    masters: gentoo
    volatile: True

gentoo-fixes
    location: /srv/repos/gentoo-fixes
    masters: gentoo
    volatile: True

ACCEPT_KEYWORDS="ppc64"
ACCEPT_LICENSE="@FREE"
CBUILD="powerpc64le-unknown-linux-gnu"
CFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
CHOST="powerpc64le-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="-j8 --keep-going --dynamic-deps=n --autounmask=n --autounmask-write=n --unordered-display --verbose-conflicts --binpkg-respect-use=y --with-bdeps-auto=n"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live ccache config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync merge-wait multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="/usr/share/cursors/xorg-x11/default   /etc/alsa/conf.d/51-pulseaudio-probe.conf   /etc/portage/*postsync.d   /etc/gssproxy/??-*.conf"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j32 -l40"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/zsh"
USE="X acl bs2b bzip2 cairo cli crypt cups dri exif flac fortran gdbm iconv icu ipv6 jpeg jpeg2k kerberos mp3 ncurses nls ogg opengl openmp opus pam pcre png ppc64 readline seccomp split-usr ssl svg test-rust threads tiff truetype unicode xattr xft xinerama zlib" ADA_TARGET="gcc_12" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_PPC="altivec vsx vsx2 vsx3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-2" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_12" PYTHON_TARGETS="python3_12" RUBY_TARGETS="ruby31 ruby32" VIDEO_CARDS="ast nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Nick Bowler 2024-07-03 15:13:12 UTC
Created attachment 896862 [details, diff]
proposed patch
Comment 2 Larry the Git Cow gentoo-dev 2024-07-04 01:29:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c627cc231796bf88ce7ef664986863d32de4a5a4

commit c627cc231796bf88ce7ef664986863d32de4a5a4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-07-04 01:28:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-04 01:28:37 +0000

    dev-libs/nettle: fix quoting for altivec sanity check
    
    Bug: https://bugs.gentoo.org/920234
    Closes: https://bugs.gentoo.org/935410
    Fixes: 4551df6ec5cae19486cb63698e294a3f62015600
    Thanks-to: Nick Bowler <nbowler@draconx.ca>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/nettle/nettle-3.10.ebuild     | 2 +-
 dev-libs/nettle/nettle-3.9.1-r1.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)