Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935368 - dev-util/cppcheck-2.13.0 fails tests on x86: [test.cpp:15]: (performance) Function parameter 's' should be passed by const reference.\n
Summary: dev-util/cppcheck-2.13.0 fails tests on x86: [test.cpp:15]: (performance) Fun...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal normal
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords: PATCH, TESTFAILURE
Depends on:
Blocks:
 
Reported: 2024-07-02 20:06 UTC by matoro
Modified: 2024-07-15 04:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log and emerge --info (file_935368.txt,463.72 KB, text/plain)
2024-07-02 20:06 UTC, matoro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description matoro archtester 2024-07-02 20:06:57 UTC
Created attachment 896818 [details]
build.log and emerge --info

This failure does not repro on amd64.

99% tests passed, 1 tests failed out of 99

Total Test time (real) =   5.23 sec

The following tests FAILED:
	 39 - TestOther (Failed)
Errors while running CTest

Testing Complete
Number of tests: 212
Number of todos: 20
Tests failed: 1

/var/tmp/portage/dev-util/cppcheck-2.13.0/work/cppcheck-2.13.0/test/testother.cpp:2193(TestOther::passedByValue): Assertion failed. 
Expected: 

Actual: 
[test.cpp:15]: (performance) Function parameter 's' should be passed by const reference.\n

_____
<end of output>
Test time =   1.23 sec
----------------------------------------------------------
Test Failed.
"TestOther" end time: Jul 02 19:52 UTC
"TestOther" time elapsed: 00:00:01
Comment 2 Larry the Git Cow gentoo-dev 2024-07-15 04:35:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bcd56fa9d549f483f7f8949860ccb460be8e4fd0

commit bcd56fa9d549f483f7f8949860ccb460be8e4fd0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-07-15 04:32:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-15 04:32:34 +0000

    dev-util/cppcheck: add 2.14.2
    
    Drop USE=threads too as the option got renamed and what it's used for
    clearly isn't worthy of a USE flag.
    
    Closes: https://bugs.gentoo.org/935368
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/cppcheck/Manifest               |   1 +
 dev-util/cppcheck/cppcheck-2.14.2.ebuild | 152 +++++++++++++++++++++++++++++++
 2 files changed, 153 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68f0e9969e5761d580346c0788186dcf471e5a0c

commit 68f0e9969e5761d580346c0788186dcf471e5a0c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-07-15 04:34:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-15 04:34:19 +0000

    dev-util/cppcheck: backport 32-bit test(-only) fix
    
    Bug: https://bugs.gentoo.org/935368
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/cppcheck/cppcheck-2.13.0.ebuild           |  4 ++++
 .../files/cppcheck-2.13.0-32-bit-tests.patch       | 28 ++++++++++++++++++++++
 2 files changed, 32 insertions(+)