Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935257 - dev-java/commons-collections-3.2.2-r2: typo "${ARCH}" = "ppc"
Summary: dev-java/commons-collections-3.2.2-r2: typo "${ARCH}" = "ppc"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-07-01 00:43 UTC by Anton Bolshakov
Modified: 2024-07-01 12:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Bolshakov 2024-07-01 00:43:39 UTC
Hi,

It looks like there is a typo in the ebuild. Please check the following block:

src_test() {
        if [[ "${ARCH}" = "ppc" ]]; then
                einfo "tests are disabled on ppc"
        else
                java-pkg-simple_src_test
        fi
}


I think it should be double "==".
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-01 11:27:19 UTC
No, = is fine for comparisons in Bash, even if == is arguably better in Bash ("when in Rome").
Comment 2 Larry the Git Cow gentoo-dev 2024-07-01 12:16:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88f572e04b7adefd50834c19725262e0e0be2d4b

commit 88f572e04b7adefd50834c19725262e0e0be2d4b
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2024-07-01 08:12:08 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-07-01 12:16:18 +0000

    dev-java/commons-collections: ppc not supported
    
    Closes: https://bugs.gentoo.org/935257
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/37382
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../commons-collections/commons-collections-3.2.2-r2.ebuild    | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)