Bug 935043 – net-p2p/retroshare-0.6.7 - [perl-5.40] [icu-75.1] [gcc-15] rs_upnp/upnphandler_miniupnp.cc: error: too few arguments to function int UPNP_GetValidIGD(UPNPDev , UPNPUrls , IGDdatas ,

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Toralf Förster 2024-06-27 19:31:34 UTC]

too long lines were shrinked:

At global scope:
cc1plus: note: unrecognized command-line option -Wno-inconsistent-missing-override may have been intended to silence earlier diagnostics
x86_64-pc-linux-gnu-g++ -c -O2 -pipe -march=native -fno-diagnostics-color -Wno-deprecated -Wno-deprecated-declarations -Wno-cpp -Wno-inconsistent-missing-override -O0 -g -fno-omit-frame-pointer -Wall -Wextra -Wno-misleading-indentation -Wno-dangling-else -fPIC -D_FILE_OFFSET_BITS=64 -fPIC -Wall -Wex
x86_64-pc-linux-gnu-g++ -c -O2 -pipe -march=native -fno-diagnostics-color -Wno-deprecated -Wno-deprecated-declarations -Wno-cpp -Wno-inconsistent-missing-override -O0 -g -fno-omit-frame-pointer -Wall -Wextra -Wno-misleading-indentation -Wno-dangling-else -fPIC -D_FILE_OFFSET_BITS=64 -fPIC -Wall -Wex
x86_64-pc-linux-gnu-g++ -c -O2 -pipe -march=native -fno-diagnostics-color -Wno-deprecated -Wno-deprecated-declarations -Wno-cpp -Wno-inconsistent-missing-override -O0 -g -fno-omit-frame-pointer -Wall -Wextra -Wno-misleading-indentation -Wno-dangling-else -fPIC -D_FILE_OFFSET_BITS=64 -fPIC -Wall -Wex
rs_upnp/upnphandler_miniupnp.cc: In member function bool upnphandler::initUPnPState():
rs_upnp/upnphandler_miniupnp.cc:140:36: error: too few arguments to function int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)
  140 |                 if(UPNP_GetValidIGD(upcd->devlist, &(upcd->urls),
      |                    ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 23.0_desktop_plasma-20240623-150127

  UNMASKED:
  <sys-devel/gcc-15.0.9999:15
    Please re-assign to toolchain@ if you get a test failure in C, C++, or Fortran code which makes no sense.
  ~dev-libs/icu-75.1
  ~dev-libs/icu-layoutex-75.1
    Requested by sam
  ~dev-lang/perl-5.40.0
  ~virtual/perl-Archive-Tar-3.20.10_rc
  ~virtual/perl-CPAN-Meta-Requirements-2.143.0
  ~virtual/perl-Compress-Raw-Bzip2-2.212.0
  ~virtual/perl-DB_File-1.859.0
  ~virtual/perl-Data-Dumper-2.189.0
  ~virtual/perl-Devel-PPPort-3.720.0
  ~virtual/perl-Exporter-5.780.0
  ~virtual/perl-ExtUtils-CBuilder-0.280.240
  ~virtual/perl-ExtUtils-Manifest-1.750.0
  ~virtual/perl-File-Spec-3.900.0
  ~virtual/perl-HTTP-Tiny-0.88.0
  ~virtual/perl-IO-1.550.0
  ~virtual/perl-IO-Compress-2.212.0
  ~virtual/perl-IO-Socket-IP-0.420.0
  ~virtual/perl-IO-Zlib-1.150.0
  ~virtual/perl-Math-BigInt-2.3.2
  ~virtual/perl-Math-BigInt-FastCalc-0.501.800
  ~virtual/perl-Math-BigRat-2.3.2
  ~virtual/perl-Module-CoreList-5.202.406.90
  ~virtual/perl-Module-Metadata-1.0.38
  ~virtual/perl-Pod-Simple-3.450.0
  ~virtual/perl-Safe-2.460.0
  ~virtual/perl-Socket-2.38.0
  ~virtual/perl-Test-Harness-3.480.0
  ~virtual/perl-Test-Simple-1.302.199
  ~virtual/perl-Text-Tabs+Wrap-2024.1.0
  ~virtual/perl-Time-HiRes-1.977.700
  ~virtual/perl-Time-Local-1.350.0
  ~virtual/perl-autodie-2.370.0
  ~virtual/perl-bignum-0.670.0
  ~virtual/perl-podlators-5.10.200_rc
  ~virtual/perl-threads-2.400.0
  ~virtual/perl-threads-shared-1.690.0
  ~virtual/perl-version-0.993.0
    Requested by dilfridge and sam

  The attached etc.portage.tar.xz has all details.
  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-15 *
clang/llvm (if any):
/usr/lib/llvm/18
18.1.8
Python 3.12.4
Available Rust versions:
  [1]   rust-bin-1.79.0
  [2]   rust-1.79.0 *
The following VMs are available for generation-2:
*)	Eclipse Temurin JDK 21.0.3_p9 [openjdk-bin-21]
Available Java Virtual Machines:
  [1]   openjdk-bin-21  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.2.8
php cli (if any):
  [1]   php8.2
  [2]   php8.3 *
go version go1.22.4 linux/amd64

  HEAD of ::gentoo
commit 6a56c2a93970f9c7a5e9de7d4b5e7f5d5559b361
Author: Repository mirror & CI <[e-mail]>
Date:   Thu Jun 27 17:03:59 2024 +0000

    2024-06-27 17:03:57 UTC

emerge -qpvO net-p2p/retroshare
[ebuild  N    ] net-p2p/retroshare-0.6.7  USE="gui jsonapi miniupnp service sqlcipher -cli -keyring -libupnp -plugins"

[Comment 1 Toralf Förster 2024-06-27 19:31:40 UTC]

Created attachment 896534 [details]
emerge-info.txt

[Comment 2 Toralf Förster 2024-06-27 19:31:43 UTC]

Created attachment 896535 [details]
emerge-history.txt

[Comment 3 Toralf Förster 2024-06-27 19:31:45 UTC]

Created attachment 896536 [details]
environment

[Comment 4 Toralf Förster 2024-06-27 19:31:47 UTC]

Created attachment 896537 [details]
etc.portage.tar.xz

[Comment 5 Toralf Förster 2024-06-27 19:31:49 UTC]

Created attachment 896538 [details]
net-p2p:retroshare-0.6.7:20240627-182325.log.xz

[Comment 6 Toralf Förster 2024-06-27 19:31:53 UTC]

Created attachment 896539 [details]
qlist-info.txt.xz

[Comment 7 Toralf Förster 2024-06-27 19:31:54 UTC]

Created attachment 896540 [details]
temp.tar.xz

[Comment 8 gentoo-setan 2024-07-02 16:05:09 UTC]

It's the same issue as in
https://bugs.gentoo.org/934058

Upstream has no fixes for it yet so I have made a PR forcing the old miniupnpc API (17)
https://github.com/gentoo/gentoo/pull/37361

[Comment 9 Larry the Git Cow 2024-07-04 01:23:12 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b0a50bdb4a417142d4e87c154bcccf87576e268

commit 9b0a50bdb4a417142d4e87c154bcccf87576e268
Author:     gentoo-setan <[e-mail]>
AuthorDate: 2024-07-03 17:56:57 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-07-04 01:22:20 +0000

    net-p2p/retroshare: Swap 0.6.7 for 0.6.7-r1, fix miniupnpc API
    
    Retroshare only recognizes API over 14:
    https://github.com/RetroShare/libretroshare/blob/402f32eda026c3ec3e429b5fb842e87ebd985d73/src/rs_upnp/upnphandler_miniupnp.cc#L50
    
    And miniupnp changed one of the functions core functions in API 18
    https://github.com/miniupnp/miniupnp/blob/3911bace98ec1593dcc41953a09f3fd657c341be/miniupnpc/apiversions.txt#L6
    
    Retroshare did not adapt so we need to pin the dep until the upstream
    resolves this issue: https://github.com/RetroShare/RetroShare/issues/2865
    
    Closes: https://bugs.gentoo.org/935043
    Signed-off-by: gentoo-setan <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/37412
    Signed-off-by: Sam James <[e-mail]>

 .../{retroshare-0.6.7.ebuild => retroshare-0.6.7-r1.ebuild}          | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)