Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934821 - net-p2p/bitcoin-core[upnp] build failed with net-libs/miniupnpc-2.2.8-r1 error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’
Summary: net-p2p/bitcoin-core[upnp] build failed with net-libs/miniupnpc-2.2.8-r1 erro...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matt Whitlock
URL: https://github.com/bitcoin/bitcoin/is...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-06-24 20:39 UTC by Alexey Shvetsov
Modified: 2024-06-26 09:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,35.06 KB, text/plain)
2024-06-24 20:39 UTC, Alexey Shvetsov 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvetsov archtester gentoo-dev 2024-06-24 20:39:35 UTC 
Seems like api of miniupnpc changed

mapport.cpp: In function ‘bool ProcessUpnp()’:
mapport.cpp:167:25: error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’
  167 |     r = UPNP_GetValidIGD(devlist, &urls, &data, lanaddr, sizeof(lanaddr));
      |         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from mapport.cpp:26:
/usr/include/miniupnpc/miniupnpc.h:122:1: note: declared here
  122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
      | ^~~~~~~~~~~~~~~~
make[2]: *** [Makefile:10693: libbitcoin_node_a-mapport.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/net-p2p/bitcoin-core-27.1/work/bitcoin-27.1/src'
make[2]: *** Waiting for unfinished jobs....
Comment 1 Alexey Shvetsov archtester gentoo-dev 2024-06-24 20:39:59 UTC 
Created attachment 896367 [details]
build.log
Comment 2 Larry the Git Cow gentoo-dev 2024-06-26 09:27:33 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef78ef66f5a4b4c92e646a45ebd20c06c756eeb3

commit ef78ef66f5a4b4c92e646a45ebd20c06c756eeb3
Author:     Matt Whitlock <gentoo@mattwhitlock.name>
AuthorDate: 2024-06-25 19:38:33 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2024-06-26 09:26:47 +0000

    net-p2p/bitcoin-core: make compat with >=net-libs/miniupnpc-2.2.8
    
    See: https://github.com/bitcoin/bitcoin/commit/8acdf66540834b9f9cf28f16d389e8b6a48516d5
    Closes: https://bugs.gentoo.org/934821
    Signed-off-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://github.com/gentoo/gentoo/pull/37301
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 net-p2p/bitcoin-core/Manifest                     | 1 +
 net-p2p/bitcoin-core/bitcoin-core-25.1-r2.ebuild  | 6 +++++-
 net-p2p/bitcoin-core/bitcoin-core-25.2.ebuild     | 6 +++++-
 net-p2p/bitcoin-core/bitcoin-core-26.0-r1.ebuild  | 6 +++++-
 net-p2p/bitcoin-core/bitcoin-core-26.1.ebuild     | 6 +++++-
 net-p2p/bitcoin-core/bitcoin-core-26.2_rc1.ebuild | 6 +++++-
 net-p2p/bitcoin-core/bitcoin-core-27.0.ebuild     | 6 +++++-
 net-p2p/bitcoin-core/bitcoin-core-27.1.ebuild     | 6 +++++-
 8 files changed, 36 insertions(+), 7 deletions(-)