Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934762 - app-office/texstudio[video]: ineffective dependency on media-libs/phonon, supports QtMultimedia instead since 4.5.1
Summary: app-office/texstudio[video]: ineffective dependency on media-libs/phonon, sup...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: TeX project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 936956
  Show dependency tree
 
Reported: 2024-06-23 10:17 UTC by Andreas Sturmlechner
Modified: 2024-10-03 15:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2024-06-23 10:17:19 UTC
> Changelog
> ## TeXstudio 4.5.1
> - use QtMultimedia instead of phonon to show movies in pdf (non-default)

4.8.1 (or some version prior to that) has:
> !isEmpty(MEDIAPLAYER){
>     QT += multimedia multimediawidgets
>     DEFINES += MEDIAPLAYER
> }

Some time after 4.5.1, phonon must have been quietly dropped by upstream, as these lines in the ebuild are ineffective:
>	if use video; then
>		sed "/^PHONON/s:$:true:g" -i ${PN}.pro || die
>	fi

That's why sed usage in ebuilds should always be verified if still applicable.

CCing maintainers who did the last bumps.
Comment 1 Larry the Git Cow gentoo-dev 2024-09-04 14:55:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7373e49c109cb56814e12ba935aa649181af5bd5

commit 7373e49c109cb56814e12ba935aa649181af5bd5
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-06-23 19:27:38 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-09-04 14:52:43 +0000

    profiles: arm: Mask app-office/texstudio[video] in package.use.mask
    
    Bug: https://bugs.gentoo.org/934762
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/arch/arm/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=84425ef89603d72cfe36d1ed9528a6d64dc11f4c

commit 84425ef89603d72cfe36d1ed9528a6d64dc11f4c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-06-23 19:25:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-09-04 14:52:39 +0000

    profiles: ppc32: Mask media-libs/phonon revdeps in package.use.mask
    
    Bug: https://bugs.gentoo.org/934762
    Bug: https://bugs.gentoo.org/934767
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/arch/powerpc/ppc32/package.use.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2024-10-03 15:57:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=420cbd16a28b6ed5e3509ad4b0ac5e00cdd39ac4

commit 420cbd16a28b6ed5e3509ad4b0ac5e00cdd39ac4
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2024-09-20 09:48:09 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2024-10-03 15:56:54 +0000

    app-office/texstudio: add 4.8.4 using qt6, drop 4.8.1
    
    Switch from qmake to cmake. Drop the .pro related unbundling patches, as
    they are not relevant to the cmake build.
    
    This also drops the unbundling of qtsingeapplication, as texstudio's
    bundled version contains Qt6 specfic guards.
    
    Thanks to ionen for constructive suggestions.
    
    Closes: https://bugs.gentoo.org/934762
    Closes: https://bugs.gentoo.org/934581
    Closes: https://github.com/gentoo/gentoo/pull/38702
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 app-office/texstudio/Manifest               |  2 +-
 app-office/texstudio/texstudio-4.8.1.ebuild | 79 -----------------------------
 app-office/texstudio/texstudio-4.8.4.ebuild | 66 ++++++++++++++++++++++++
 3 files changed, 67 insertions(+), 80 deletions(-)